⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Conversation

@cjen1-msft
Copy link
Contributor

We only intend to use self-healing-open when local sealing is available, so we should run all of our tests in that environment.

@cjen1-msft cjen1-msft requested a review from a team as a code owner January 14, 2026 15:07
Copilot AI review requested due to automatic review settings January 14, 2026 15:07
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR modifies the self-healing-open test functions to enforce that they only run with local sealing enabled, as per the intended use case. The removed run_self_healing_open_local_unsealing function is consolidated into the main run_self_healing_open test, and all three self-healing-open tests are moved to run only in the SNP test suite (which has local sealing available).

Changes:

  • Added enable_local_sealing = True to run_self_healing_open function and updated its label
  • Simplified test assertions by removing redundant recovery share submission and network opening checks
  • Removed the duplicate run_self_healing_open_local_unsealing function (75 lines)
  • Moved all three self-healing-open tests from run() to run_snp_tests() to ensure they only execute in environments with local sealing
Comments suppressed due to low confidence (2)

tests/e2e_operations.py:1813

  • The function run_self_healing_open_timeout_path is missing args.enable_local_sealing = True like the other self-healing-open functions. According to the PR description, all self-healing-open tests should run with local sealing enabled.
    args.label += "_self_healing_open_timeout"

tests/e2e_operations.py:1871

  • The function run_self_healing_open_multiple_timeout is missing args.enable_local_sealing = True like run_self_healing_open. According to the PR description, all self-healing-open tests should run with local sealing enabled.
    args.label += "_self_healing_open_multiple_timeout"

@cjen1-msft cjen1-msft marked this pull request as draft January 14, 2026 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant