Use CBOR wrappers in COSE auth #7574
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yet another step towards #7542
Faced difficulties with error handling for optionals, as in
Doing two lookups as in
needs reiterating, and simply
doesn't work, because map_at() returns const T&.
At the end, I decided to categorise errors. Now each has a concrete
Errorincluded, which can be used to classify errors and either rethrow or silence.❗ This changes the existing behaviour for
TimestampedProtectedHeaderwithstd::optional<uint64_t> msg_created_at;. Previously, it'd have silently avoid that field if it was negative, however it looks wrong to me, so we'll fail if the filed is present but ill-formed.