Add new --append option to IndexBuilder to support adding new items to an existing index#58
Open
MaJaHa95 wants to merge 4 commits intomicrosoft:mainfrom
Open
Add new --append option to IndexBuilder to support adding new items to an existing index#58MaJaHa95 wants to merge 4 commits intomicrosoft:mainfrom
MaJaHa95 wants to merge 4 commits intomicrosoft:mainfrom
Conversation
|
|
MaJaHa95
commented
May 30, 2019
| code = indexBuilder->BuildIndex(vectorReader->GetVectorSet(), vectorReader->GetMetadataSet()); | ||
| indexBuilder->SaveIndex(options->m_outputFolder); | ||
|
|
||
| p_vectorSet = vectorReader->GetVectorSet(); |
Author
There was a problem hiding this comment.
Is there an issue with using the out-of-scope vectorReader here? I wasn't sure about the lifetime of it, whether there could be an issue. Again, new to all this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From what I can tell, there's no ability with the CLI to append data onto an existing index; running IndexBuilder starts afresh.
This PR adds an
--appendparameter to IndexBuilder, which attempts to load an existing index, and calls theVectorIndex::AddIndexfunction if it already exists.I'm pretty new to C++ (from C#, so look out), so there are some changes I'm not totally confident about. But it seems pretty simple.