-
Notifications
You must be signed in to change notification settings - Fork 294
Research: Add fontkit support alongside opentype.js #640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: danmarshall <[email protected]>
Co-authored-by: danmarshall <[email protected]>
|
@copilot thank you. I didnt want you to implement it, since I have some opinions about that. I would not add a new TextAuto model - I would just have an if inside of Text - where we would use your duck typing to branch. This way we don't fall to LCD but we can have extra goodness from fontkit. And here is what I wanted to talk about extra: some fonts or unicode characters can have color right? These would go into layers by color. |
…upport Co-authored-by: danmarshall <[email protected]>
Done in commit 24e7e45. The implementation now:
The API is unchanged - same Text constructor works with either library transparently. |
Co-authored-by: danmarshall <[email protected]>
|
Please... the list of features / functions is just hype. Where's the real comparison of font handling, kernel handling, etc. @copilot could do more if it was a real person. Obviously, a real person started the effort... |
|
@copilot actually y is upside down: |
Co-authored-by: danmarshall <[email protected]>
|
@copilot can you remove the optionalDependencies in package.json and use @types/fontkit instead? |
…pendencies Co-authored-by: danmarshall <[email protected]>
Done in commit c4e8eae. Removed fontkit from optionalDependencies and added @types/fontkit (v2.0.8) to devDependencies. Users who want fontkit features will install it separately with |

Research: Adding fontkit support in addition to opentype.js
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.