⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

fix: constrain torch version and add transformers dependency #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mahone3297 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: constrain torch version and add transformers dependency #232

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,9 @@ classifiers = [
]
requires-python = ">=3.10"
dependencies = [
"torch >= 2.6",
"torch <= 2.8",
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The torch dependency has been changed from >= 2.6 to <= 2.8. This removes the lower version bound, which could allow older, incompatible versions of PyTorch to be installed. To ensure compatibility, it's better to specify both a lower and an upper bound, combining the previous constraint with the new one.

Suggested change
"torch <= 2.8",
"torch >= 2.6, <= 2.8",

"torchvision",
"transformers",
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The transformers dependency is added without a version constraint. This can lead to unexpected issues if a future version introduces breaking changes. The development dependencies specify transformers == 4.52.4. It is a good practice to specify a compatible version range to ensure stability.

Suggested change
"transformers",
"transformers >= 4.52.4, < 5.0",

"numpy",
"safetensors",
"gguf",
Expand Down