Conversation
Summary of ChangesHello @DanJun6737, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on updating documentation across several README files within the repository. The main goal is to announce recent academic achievements, specifically the acceptance of 'TransFace++' to TPAMI, and to enrich existing project documentation for 'TopoFR' and 'TransFace' with new resource links, including a Hugging Face demo for 'TopoFR' and updated publication details. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates several README files to announce the acceptance of 'TransFace++' to TPAMI and adds related links and information. My review focuses on improving the structure and consistency of the documentation. I've pointed out issues with duplicated content in the main READMEs, invalid HTML structure, and minor formatting improvements for markdown link readability. These changes will help ensure the documentation is clear, consistent, and renders correctly.
| <h2 align="center">TopoFR: A Closer Look at Topology Alignment on Face Recognition | ||
| <h5 align="center"> If you like TopoFR, please give us a star ⭐ on GitHub for the latest update~ | ||
| <h5 align="center"> <a href='https://huggingface.co/spaces/developer0hye/TopoFR-Face-Recognition'><img src='https://img.shields.io/badge/%F0%9F%A4%97%20Hugging%20Face-Demo-blue'></a> | ||
|
|
||
| </h2> |
There was a problem hiding this comment.
The HTML structure here is invalid because heading elements like <h5> cannot be nested inside another heading element like <h2>. This can cause rendering issues on some markdown parsers. Please move the <h5> tags to be siblings of the <h2> tag, not children.
| # News | ||
| - Our work [TransFace++](https://ieeexplore.ieee.org/document/11184862) got accepted to TPAMI ! (September 30th, 2025 UTC) |
There was a problem hiding this comment.
This file contains two 'News' sections. This new item is being added to both, which is redundant. To improve readability and maintainability, it's recommended to have a single, consolidated 'News' section. Please consider removing this shorter, top-level 'News' section and keeping only the more comprehensive one that starts around line 40.
| # 最新消息 | ||
| - Facechain算法创新工作[TransFace++](https://ieeexplore.ieee.org/abstract/document/11184862) 在期刊TPAMI上发表! (2025-09-30) |
There was a problem hiding this comment.
This file contains two news sections, one under # 最新消息 and another under # News. This is redundant and the English heading in a Chinese README is inconsistent. To improve clarity, consider merging them into a single section under the Chinese heading (# 最新消息).
| <p> | ||
|
|
||
| # 最新消息 | ||
| - Facechain算法创新工作[TransFace++](https://ieeexplore.ieee.org/abstract/document/11184862) 在期刊TPAMI上发表! (2025-09-30) |
There was a problem hiding this comment.
The link for TransFace++ here (.../abstract/document/...) is different from the one in the English README.md (.../document/...). For consistency across documentation, it's recommended to use the same URL in both files.
| - Facechain算法创新工作[TransFace++](https://ieeexplore.ieee.org/abstract/document/11184862) 在期刊TPAMI上发表! (2025-09-30) | |
| - Facechain算法创新工作[TransFace++](https://ieeexplore.ieee.org/document/11184862) 在期刊TPAMI上发表! (2025-09-30) |
|
|
||
|
|
||
| # News | ||
| - Facechain算法创新工作[TransFace++](https://ieeexplore.ieee.org/abstract/document/11184862) 在期刊TPAMI上发表! (2025-09-30) |
There was a problem hiding this comment.
The link for TransFace++ here (.../abstract/document/...) is different from the one in the English README.md (.../document/...). For consistency across documentation, it's recommended to use the same URL in both files.
| - Facechain算法创新工作[TransFace++](https://ieeexplore.ieee.org/abstract/document/11184862) 在期刊TPAMI上发表! (2025-09-30) | |
| - Facechain算法创新工作[TransFace++](https://ieeexplore.ieee.org/document/11184862) 在期刊TPAMI上发表! (2025-09-30) |
| This is the official PyTorch implementation of ["[NeurIPS 2024] TopoFR: A Closer Look at Topology Alignment on Face Recognition"](https://proceedings.neurips.cc/paper_files/paper/2024/hash/419b6c974712adb884bfbbeea8e94d1b-Abstract-Conference.html). | ||
|
|
||
|
|
||
| [[Arxiv Version]](https://arxiv.org/abs/2410.10587) [[Code in Co-Author’s Rep.]](https://github.com/DanJun6737/TopoFR)[[机器之心]](https://www.jiqizhixin.com/articles/2024-10-17-6) [[CVer]](https://mp.weixin.qq.com/s/3NegnpJUGPfI_dOfkp_4LQ) [[CSDN]](https://blog.csdn.net/sunbaigui/article/details/143230746?spm=1001.2014.3001.5502) |
There was a problem hiding this comment.
For better readability of the markdown source code, it's a good practice to add spaces between adjacent link definitions.
| [[Arxiv Version]](https://arxiv.org/abs/2410.10587) [[Code in Co-Author’s Rep.]](https://github.com/DanJun6737/TopoFR)[[机器之心]](https://www.jiqizhixin.com/articles/2024-10-17-6) [[CVer]](https://mp.weixin.qq.com/s/3NegnpJUGPfI_dOfkp_4LQ) [[CSDN]](https://blog.csdn.net/sunbaigui/article/details/143230746?spm=1001.2014.3001.5502) | |
| [[Arxiv Version]](https://arxiv.org/abs/2410.10587) [[Code in Co-Author’s Rep.]](https://github.com/DanJun6737/TopoFR) [[机器之心]](https://www.jiqizhixin.com/articles/2024-10-17-6) [[CVer]](https://mp.weixin.qq.com/s/3NegnpJUGPfI_dOfkp_4LQ) [[CSDN]](https://blog.csdn.net/sunbaigui/article/details/143230746?spm=1001.2014.3001.5502) |
1 participant
Update TransFace++