⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

fix: video gen exclude edit_file#861

Merged
suluyana merged 1 commit intomodelscope:mainfrom
suluyana:fix/video_gen_exclude_edit_file
Feb 6, 2026
Merged

fix: video gen exclude edit_file#861
suluyana merged 1 commit intomodelscope:mainfrom
suluyana:fix/video_gen_exclude_edit_file

Conversation

@suluyana
Copy link
Collaborator

@suluyana suluyana commented Feb 6, 2026

Change Summary

Related issue number

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Run pre-commit install and pre-commit run --all-files before git commit, and passed lint check.
  • Documentation reflects the changes where applicable

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @suluyana, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request modifies the agent.yaml file to exclude the edit_file tool. This change restricts the agent's capabilities, specifically preventing it from directly editing files, which is likely a security measure to limit potential risks associated with arbitrary file modifications.

Highlights

  • Tool Exclusion: The edit_file tool has been added to the exclusion list in the agent.yaml configuration file.
  • Security Enhancement: By excluding edit_file, the agent is prevented from directly modifying files, enhancing security.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • projects/singularity_cinema/agent.yaml
    • Added edit_file to the list of excluded tools.
Activity
  • The pull request introduces a configuration change to restrict the agent's file editing capabilities.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request excludes the edit_file tool for the video generation agent, which is a good security measure. My review includes a suggestion to also exclude other unnecessary file modification tools to further restrict the agent's capabilities to only what is essential for its task, following the principle of least privilege.

@suluyana suluyana merged commit 6ed0679 into modelscope:main Feb 6, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants