Fix formatting of commented out lines of code#646
Open
AdamPettinger wants to merge 2 commits intomoveit:masterfrom
Open
Fix formatting of commented out lines of code#646AdamPettinger wants to merge 2 commits intomoveit:masterfrom
AdamPettinger wants to merge 2 commits intomoveit:masterfrom
Conversation
f62c5a8 to
38c2509
Compare
rhaschke
reviewed
Jun 9, 2021
Contributor
rhaschke
left a comment
There was a problem hiding this comment.
Why should the robot not move? In simulation that shouldn't be a problem.
38c2509 to
58d4ed7
Compare
Contributor
Author
Good question... The short answer: because that is how it was before this PR. The longer answer: this tutorial wasn't always planning starting from the end of the previous plan, so some of the plans being executed was causing problems with the starting state and the robot state not being the same. I reworked the flow of the tutorial a bit to show the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Move Group C++ Interface tutorial for Noetic has some of the move/execute lines commented out:
// move_group_interface.execute(my_plan);// move_group_interface.move();which makes the tutorial formatting add these as plain text and makes the page look weird:

This PR changes those lines so they appear as code that is commented out.
It also comments out an
executecall later in the tutorial that gives a "no controllers found" warning if left inChecklist