Switch to safe-utf 7 to avoid vulnerability notifications#911
Open
alisonaquinas wants to merge 3 commits intomscdex:masterfrom
Open
Switch to safe-utf 7 to avoid vulnerability notifications#911alisonaquinas wants to merge 3 commits intomscdex:masterfrom
alisonaquinas wants to merge 3 commits intomscdex:masterfrom
Conversation
Author
|
got back to me and pointed me to https://github.com/kkaefer/utf7/, I've posted kkaefer/utf7#15 |
Author
|
I've not heard back from Konstantin despite my best efforts. He's not been merging PRs at all, given the state of other PRs and issues. My latest version removes the need for |
|
Hi! are there some news about this MR? |
|
Fixes #905. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been working with this library recently for a personal project, and I'm hugely grateful for the work that's gone into it! The problem I ran into is that semver, a dependency of utf7 has a known vulnerability:
Unfortunately, Konstantin, who created the utf7 library, never published the code on a public repository where a Pull request could be submitted. I've reached out to him directly, but in the meantime, I introduced https://github.com/alisonaquinas/node-safe-utf7 to resolve the issue.