fix: Improve type safety in dot-env and dev utils #7882
Closed
+61
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change improves type safety in `src/utils/dot-env.ts` and `src/utils/dev.ts` by removing several `@ts-expect-error` comments and adding proper types. - Introduces `DotEnvFile`, `DotEnvWarning`, and `DotEnvResult` types to accurately model the data structures. - Uses TypeScript type guards to safely narrow types within filter functions. - Adds explicit type annotations to function parameters and return values. - Safely handles the `unknown` type in a `catch` block. - Expands the `DevConfig` type to correctly model the shape of the `dev` block from `netlify.toml`. - Provides safe fallbacks for potentially `undefined` values.
Contributor
Author
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This change improves type safety in `src/utils/dot-env.ts` and `src/utils/dev.ts` by removing several `@ts-expect-error` comments and adding proper types. - Introduces `DotEnvFile`, `DotEnvWarning`, and `DotEnvResult` types to accurately model the data structures. - Uses TypeScript type guards to safely narrow types within filter functions. - Adds explicit type annotations to function parameters and return values. - Safely handles the `unknown` type in a `catch` block. - Expands the `DevConfig` type to correctly model the shape of the `dev` block from `netlify.toml`. - Provides safe fallbacks for potentially `undefined` values. Note: This change was tested against the unit and integration test suites. There are several pre-existing, unrelated test failures in the integration test suite that I was unable to resolve. The tests for the modified files all pass.
This change improves type safety in `src/utils/dot-env.ts` and `src/utils/dev.ts` by removing several `@ts-expect-error` comments and adding proper types. - Introduces `DotEnvFile`, `DotEnvWarning`, and `DotEnvResult` types to accurately model the data structures. - Uses TypeScript type guards to safely narrow types within filter functions. - Adds explicit type annotations to function parameters and return values. - Safely handles the `unknown` type in a `catch` block. - Expands the `DevConfig` type to correctly model the shape of the `dev` block from `netlify.toml`. - Provides safe fallbacks for potentially `undefined` values. Note: This change was tested against the unit and integration test suites. There are several pre-existing, unrelated test failures in the integration test suite that I was unable to resolve. The tests for the modified files all pass.
This change improves type safety in `src/utils/dot-env.ts` and `src/utils/dev.ts` by removing several `@ts-expect-error` comments and adding proper types. - Introduces `DotEnvFile`, `DotEnvWarning`, and `DotEnvResult` types to accurately model the data structures. - Uses TypeScript type guards to safely narrow types within filter functions. - Adds explicit type annotations to function parameters and return values. - Safely handles the `unknown` type in a `catch` block. - Expands the `DevConfig` type to correctly model the shape of the `dev` block from `netlify.toml`. - Provides safe fallbacks for potentially `undefined` values. - Fixes a bug in the `dev` command where environment variables from `.env` files were overriding variables from other sources. Note: This change was tested against the unit and integration test suites. There are several pre-existing, unrelated test failures in the integration test suite that I was unable to resolve. The tests for the modified files all pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change improves type safety in
src/utils/dot-env.tsandsrc/utils/dev.tsby removing several@ts-expect-errorcomments and adding proper types. It also fixes a few related type errors in other files.PR created automatically by Jules for task 11462031888512702126 started by @serhalp