feat: Use time.monotonic to avoid endless loop when using time machine

[chrfwow]

This PR

Use time.monotonic to avoid endless loop when using time machine in tests

Related Issues

Fixes #329

[gemini-code-assist]

Summary of Changes

Hello @chrfwow, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical issue where tests using time manipulation tools could lead to infinite loops in gRPC connection attempts. By adopting time.monotonic() for timeout calculations, the system ensures robust and predictable behavior regardless of system clock adjustments, thereby enhancing test reliability and overall stability. Additionally, it includes an update to the grpcio dependency.

Highlights

• Preventing Endless Loops in Tests: The core change involves switching from time.time() to time.monotonic() for timeout calculations within gRPC connection logic. This prevents potential endless loops in tests that manipulate system time using 'time machine' utilities.
• Dependency Update: The grpcio dependency has been updated from version 1.68.1 to 1.76.0 in pyproject.toml.
• Code Simplification: The self.start_time attribute and its assignments have been removed from GrpcResolver and GrpcWatcher classes, as it is no longer necessary with the use of time.monotonic().

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly replaces time.time() with time.monotonic() for timeout calculations, which prevents issues with system clock changes, particularly in test environments. This is a solid improvement for robustness. The removal of the unused self.start_time attribute is also a good cleanup.

I've added a couple of suggestions to further improve the synchronization logic by using threading.Event instead of a busy-wait loop. This would make the implementation more efficient and idiomatic.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.51%. Comparing base (9ad25a4) to head (c66ecf2).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #330      +/-   ##
==========================================
- Coverage   95.53%   95.51%   -0.03%     
==========================================
  Files          16       16              
  Lines         874      870       -4     
==========================================
- Hits          835      831       -4     
  Misses         39       39              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[gruebel]

thanks, looks good 🍻 as you stated no need to tackle the suggestion in this PR