⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Conversation

@PGijsbers
Copy link
Contributor

@PGijsbers PGijsbers commented Jan 19, 2026

because the snapshot does not work with 9.x

@PGijsbers PGijsbers changed the title Pin MySQL to 8.4 because the snapshot does not work with 9.x Pin MySQL to 8.4 Jan 19, 2026
@coderabbitai
Copy link

coderabbitai bot commented Jan 19, 2026

Walkthrough

The Docker MySQL Dockerfile has been updated to use a specific base image version. The base image tag has been changed from mysql to mysql:8.4. This change pins the MySQL image to version 8.4 instead of relying on the default tag. All other Dockerfile instructions, including initialization scripts and runtime configuration, remain unchanged. This represents a single-line modification to the FROM statement in the Dockerfile.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically summarizes the main change: pinning MySQL to version 8.4, which is the exact purpose of the changeset.
Description check ✅ Passed The description provides relevant context about why the change was made: MySQL 9.x has snapshot compatibility issues, which directly relates to the modification.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Jan 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@d150131). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #231   +/-   ##
=======================================
  Coverage        ?   53.50%           
=======================================
  Files           ?       32           
  Lines           ?     1112           
  Branches        ?      100           
=======================================
  Hits            ?      595           
  Misses          ?      516           
  Partials        ?        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@PGijsbers PGijsbers merged commit 1d39176 into main Jan 19, 2026
8 checks passed
@PGijsbers PGijsbers deleted the docker-pin-mysql-version branch January 19, 2026 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants