⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Ipsec NPT with packet capture #73607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
SachinNinganure wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Ipsec NPT with packet capture #73607

SachinNinganure wants to merge 8 commits into from

Conversation

@SachinNinganure
Copy link
Contributor

@SachinNinganure SachinNinganure commented Jan 16, 2026

No description provided.

@openshift-ci openshift-ci bot requested review from capolrik and memodi January 16, 2026 07:58
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 16, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: SachinNinganure
Once this PR has been reviewed and has the lgtm label, please assign josecastillolema for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@SachinNinganure
Copy link
Contributor Author

SachinNinganure commented Jan 16, 2026

/pj-rehearse pull-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.21-nightly-x86-data-path-ipsec-9nodes

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 16, 2026

@SachinNinganure: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@SachinNinganure
Copy link
Contributor Author

SachinNinganure commented Jan 16, 2026

/pj-rehearse pull-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.21-nightly-x86-data-path-ipsec-9nodes

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 16, 2026

@SachinNinganure: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 16, 2026

@SachinNinganure, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not load configuration from base revision of release repo: could not checkout worktree: '[git checkout 24315bda72e125e8b7154f1561ff045563cb4b42]' failed with out:  and error exec: Stdout already set
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@SachinNinganure-zz
ipsec data path 421
679d711
@SachinNinganure-zz
- Uses internal cluster validation (e2e netw approach)
7da1f14 
  - Validates EgressIP custom resource configuration and assignment
  - Tests internal routing behavior between pods
  - Extracts correct egress IPs from node annotations
@SachinNinganure-zz
- Uses internal cluster validation (e2e netw approach)
8f3879c 
  - Validates EgressIP custom resource configuration and assignment
  - Tests internal routing behavior between pods
  - Extracts correct egress IPs from node annotations
@SachinNinganure-zz
internal git issue
9566b84
@SachinNinganure-zz
Add IPSec network performance verification step with packet capture │
ce641f4 
│                                                                                                                                                                      │
│   - Fixes git dependency issue causing test failures in data-path-ipsec-9nodes                                                                                       │
│   - Adds comprehensive packet capture for IPSec verification                                                                                                         │
│   - Captures ESP packets to prove encryption status                                                                                                                  │
│   - Generates artifacts for dev team analysis                                                                                                                        │
│   - Includes IPSec status and configuration logging                                                                                                                  │
│   - Declares required ADDITIONAL_WORKER_NODES parameter                                                                                                              │
│                                                                                                                                                                      │
│   This addresses the 'git: command not found' error and provides                                                                                                     │
│   definitive evidence of whether IPSec encryption is working
@SachinNinganure-zz
Fix privilege issues in git installation for IPSec verification test │
2198787 
│                                                                                                                                                                      │
│   - Add sudo support for package manager installations                                                                                                               │
│   - Implement fallback download method using curl/wget + tar                                                                                                         │
│   - Handle cases where git binary might exist in alternative paths                                                                                                   │
│   - Ensure robust repository download without requiring root privileges                                                                                              │
│
@SachinNinganure-zz
Move virtual environment creation to /tmp directory where container h…
1d1208a 
…as write permissions
@SachinNinganure-zz
Fix git clone fallback handling
9dccaf1
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 16, 2026

[REHEARSALNOTIFIER]
@SachinNinganure: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.19-nightly-x86-data-path-ipsec-9nodes openshift-eng/ocp-qe-perfscale-ci presubmit Presubmit changed
pull-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.20-nightly-x86-data-path-ipsec-9nodes openshift-eng/ocp-qe-perfscale-ci presubmit Presubmit changed
pull-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.21-nightly-x86-data-path-ipsec-9nodes openshift-eng/ocp-qe-perfscale-ci presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 16, 2026

@SachinNinganure: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift-eng/ocp-qe-perfscale-ci/main/aws-4.21-nightly-x86-data-path-ipsec-9nodes c600ab9 link unknown /pj-rehearse pull-ci-openshift-eng-ocp-qe-perfscale-ci-main-aws-4.21-nightly-x86-data-path-ipsec-9nodes

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@capolrik capolrik Awaiting requested review from capolrik

@memodi memodi Awaiting requested review from memodi

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SachinNinganure @openshift-ci-robot @SachinNinganure-zz