-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add missing Storage Account kind for Azure Stack boot diagnostics job #73625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
/pj-rehearse periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-stack-ipi-boot-diagnostics-usermanaged-f28 |
|
@gpei: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-stack-ipi-boot-diagnostics-usermanaged-f28 |
|
@gpei: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-stack-ipi-boot-diagnostics-usermanaged-f28 |
|
@gpei: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-stack-ipi-boot-diagnostics-usermanaged-f28 |
|
@gpei: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-stack-ipi-boot-diagnostics-usermanaged-f28 |
|
@gpei: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
b3bf4e1 to
9349abc
Compare
|
cc @jinyunma for the review, thanks |
|
The boot diagnostics check on worker VMs failed for bug https://issues.redhat.com/browse/OCPBUGS-74076, so the rehearsal job failed but other parts should be ok. |
| else | ||
| echo "ERROR: failed to get boot diagnostics log on node ${node}!" | ||
| echo "Error output: ${boot_log}" | ||
| ret=1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like that blob for console log is not generated even for vm running for a while. Is it possible to also add screenshot check? Just make sure that boot diagnostics works well.
I ran below commands locally, it works.
$ VM_ID=$(az vm show --name $VM_NAME --resource-group $RG_NAME --query "vmId" -o tsv)
$ STORAGE_URI=$(az vm show --name $VM_NAME --resource-group $RG_NAME --query "diagnosticsProfile.bootDiagnostics.storageUri" -o tsv)
$ STORAGE_ACCOUNT=$(echo $STORAGE_URI | sed 's|https://||' | sed 's|\..*||')
$ CONTAINER_NAME="bootdiagnostics-${STORAGE_ACCOUNT:0:9}-${VM_ID}"
$ az storage blob list --account-name $STORAGE_ACCOUNT --container-name $CONTAINER_NAME --query "[].{Name:name, Size:properties.contentLength}" -otable
Name Size
--------------------------------------------------------------------------------------- ------
ci-op-dkynvt96-4055a-blfxq-master-0.4da372e1-f435-4ebc-83b2-bff20fc2f7f5.screenshot.bmp 11171
Then check that blob ending with screenshot.bmp is created. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the screenshot blob check, and it passed in the latest rehearsal.
Checking boot diagnostics log on Azure Stack Hub node ci-op-0cqthn88-fce37-x8lh7-master-1...
INFO: boot diagnostics configured on node ci-op-0cqthn88-fce37-x8lh7-master-1 (blob not yet generated - this is normal for healthy VMs)
Verifying boot diagnostics by checking for screenshot blob...
Checking container: bootdiagnostics-ciop0cqth-b9dc93cb-7366-4372-a48a-d0c2dfb384f1 in storage account: e197a635f03cf70sa
INFO: boot diagnostics screenshot blob found for node ci-op-0cqthn88-fce37-x8lh7-master-1: WARNING:
...
ci-op-0cqthn88-fce37-x8lh7-master-1.b9dc93cb-7366-4372-a48a-d0c2dfb384f1.screenshot.bmp
|
/pj-rehearse periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-stack-ipi-boot-diagnostics-usermanaged-f28 |
|
@gpei: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-stack-ipi-boot-diagnostics-usermanaged-f28 |
|
@gpei: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-stack-ipi-boot-diagnostics-usermanaged-f28 |
|
@gpei: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gpei The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3d8509a to
3ace27f
Compare
|
[REHEARSALNOTIFIER]
A total of 48 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
[REHEARSALNOTIFIER]
A total of 48 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
This PR fixes Azure Stack Hub boot diagnostics CI jobs by addressing two compatibility issues with Azure Stack Hub's older API profile (2019-03-01-hybrid):