⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Conversation

@gpei
Copy link
Contributor

@gpei gpei commented Jan 16, 2026

This PR fixes Azure Stack Hub boot diagnostics CI jobs by addressing two compatibility issues with Azure Stack Hub's older API profile (2019-03-01-hybrid):

  1. Storage Account Kind: Azure Stack Hub only supports Storage kind storage accounts, not StorageV2
  2. Boot Diagnostics Commands: Azure Stack Hub's API profile only has get-boot-log, not the newer get-boot-log-uris command

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2026
@openshift-ci openshift-ci bot requested review from jhou1 and yunjiang29 January 16, 2026 12:35
@gpei
Copy link
Contributor Author

gpei commented Jan 16, 2026

/pj-rehearse periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-stack-ipi-boot-diagnostics-usermanaged-f28

@openshift-ci-robot
Copy link
Contributor

@gpei: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@gpei
Copy link
Contributor Author

gpei commented Jan 17, 2026

/pj-rehearse periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-stack-ipi-boot-diagnostics-usermanaged-f28

@openshift-ci-robot
Copy link
Contributor

@gpei: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@gpei
Copy link
Contributor Author

gpei commented Jan 17, 2026

/pj-rehearse periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-stack-ipi-boot-diagnostics-usermanaged-f28

@openshift-ci-robot
Copy link
Contributor

@gpei: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@gpei
Copy link
Contributor Author

gpei commented Jan 19, 2026

/pj-rehearse periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-stack-ipi-boot-diagnostics-usermanaged-f28

@openshift-ci-robot
Copy link
Contributor

@gpei: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@gpei
Copy link
Contributor Author

gpei commented Jan 19, 2026

/pj-rehearse periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-stack-ipi-boot-diagnostics-usermanaged-f28

@openshift-ci-robot
Copy link
Contributor

@gpei: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@gpei gpei force-pushed the add_missing_storage_kind branch from b3bf4e1 to 9349abc Compare January 19, 2026 07:53
@gpei
Copy link
Contributor Author

gpei commented Jan 19, 2026

cc @jinyunma for the review, thanks

@gpei
Copy link
Contributor Author

gpei commented Jan 19, 2026

The boot diagnostics check on worker VMs failed for bug https://issues.redhat.com/browse/OCPBUGS-74076, so the rehearsal job failed but other parts should be ok.

else
echo "ERROR: failed to get boot diagnostics log on node ${node}!"
echo "Error output: ${boot_log}"
ret=1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like that blob for console log is not generated even for vm running for a while. Is it possible to also add screenshot check? Just make sure that boot diagnostics works well.

I ran below commands locally, it works.

$ VM_ID=$(az vm show --name $VM_NAME --resource-group $RG_NAME  --query "vmId" -o tsv)
$ STORAGE_URI=$(az vm show --name $VM_NAME --resource-group $RG_NAME  --query "diagnosticsProfile.bootDiagnostics.storageUri" -o tsv)
$ STORAGE_ACCOUNT=$(echo $STORAGE_URI | sed 's|https://||' | sed 's|\..*||')
$ CONTAINER_NAME="bootdiagnostics-${STORAGE_ACCOUNT:0:9}-${VM_ID}"
$ az storage blob list --account-name $STORAGE_ACCOUNT --container-name $CONTAINER_NAME --query "[].{Name:name, Size:properties.contentLength}" -otable
Name                                                                                     Size
---------------------------------------------------------------------------------------  ------
ci-op-dkynvt96-4055a-blfxq-master-0.4da372e1-f435-4ebc-83b2-bff20fc2f7f5.screenshot.bmp  11171

Then check that blob ending with screenshot.bmp is created. WDYT?

Copy link
Contributor Author

@gpei gpei Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the screenshot blob check, and it passed in the latest rehearsal.

Checking boot diagnostics log on Azure Stack Hub node ci-op-0cqthn88-fce37-x8lh7-master-1...
INFO: boot diagnostics configured on node ci-op-0cqthn88-fce37-x8lh7-master-1 (blob not yet generated - this is normal for healthy VMs)
Verifying boot diagnostics by checking for screenshot blob...
Checking container: bootdiagnostics-ciop0cqth-b9dc93cb-7366-4372-a48a-d0c2dfb384f1 in storage account: e197a635f03cf70sa
INFO: boot diagnostics screenshot blob found for node ci-op-0cqthn88-fce37-x8lh7-master-1: WARNING: 
...
ci-op-0cqthn88-fce37-x8lh7-master-1.b9dc93cb-7366-4372-a48a-d0c2dfb384f1.screenshot.bmp

@gpei
Copy link
Contributor Author

gpei commented Jan 19, 2026

/pj-rehearse periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-stack-ipi-boot-diagnostics-usermanaged-f28

@openshift-ci-robot
Copy link
Contributor

@gpei: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@gpei
Copy link
Contributor Author

gpei commented Jan 19, 2026

/pj-rehearse periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-stack-ipi-boot-diagnostics-usermanaged-f28

@openshift-ci-robot
Copy link
Contributor

@gpei: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@gpei
Copy link
Contributor Author

gpei commented Jan 19, 2026

/pj-rehearse periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-stack-ipi-boot-diagnostics-usermanaged-f28

@openshift-ci-robot
Copy link
Contributor

@gpei: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 19, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gpei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gpei gpei force-pushed the add_missing_storage_kind branch from 3d8509a to 3ace27f Compare January 19, 2026 16:27
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@gpei: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-verification-tests-main-installation-nightly-4.20-azure-ipi-identity-default-mini-perm-arm-f28 N/A periodic Registry content changed
periodic-ci-openshift-verification-tests-main-installation-nightly-4.19-azure-ipi-byo-multi-user-assigned-identity-mini-perm-arm-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.22-multi-nightly-azure-ipi-identity-none-mini-perm-arm-f14 N/A periodic Registry content changed
periodic-ci-openshift-verification-tests-main-installation-nightly-4.20-azure-ipi-mag-boot-diagnostics-usermanaged-arm-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.20-multi-nightly-azure-ipi-identity-none-mini-perm-arm-f14 N/A periodic Registry content changed
periodic-ci-openshift-verification-tests-main-installation-nightly-4.20-azure-ipi-boot-diagnostics-managed-arm-f28 N/A periodic Registry content changed
periodic-ci-openshift-verification-tests-main-installation-nightly-4.20-azure-ipi-boot-diagnostics-usermanaged-mini-perm-arm-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.21-multi-nightly-4.21-upgrade-from-stable-4.21-azure-ipi-identity-none-mini-perm-arm-f60 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.20-multi-nightly-4.20-upgrade-from-stable-4.20-azure-ipi-identity-none-mini-perm-arm-f60 N/A periodic Registry content changed
periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-ipi-mag-boot-diagnostics-usermanaged-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.22-multi-nightly-azure-ipi-identity-none-amd-f28-destructive N/A periodic Registry content changed
periodic-ci-openshift-verification-tests-main-installation-nightly-4.19-azure-ipi-boot-diagnostics-managed-arm-f28 N/A periodic Registry content changed
periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-ipi-byo-user-assigned-identity-arm-f14 N/A periodic Registry content changed
periodic-ci-openshift-verification-tests-main-installation-nightly-4.21-azure-ipi-byo-multi-user-assigned-identity-mini-perm-arm-f28 N/A periodic Registry content changed
periodic-ci-openshift-verification-tests-main-installation-nightly-4.21-azure-stack-ipi-boot-diagnostics-usermanaged-f28 N/A periodic Registry content changed
periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-ipi-identity-default-arm-f28 N/A periodic Registry content changed
periodic-ci-openshift-verification-tests-main-installation-nightly-4.21-azure-stack-ipi-boot-diagnostics-disabled-f28 N/A periodic Registry content changed
periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-ipi-boot-diagnostics-managed-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.19-multi-nightly-azure-ipi-identity-none-amd-f28-destructive N/A periodic Registry content changed
periodic-ci-openshift-verification-tests-main-installation-nightly-4.19-azure-ipi-identity-default-arm-f28 N/A periodic Registry content changed
periodic-ci-openshift-verification-tests-main-installation-nightly-4.21-azure-ipi-boot-diagnostics-managed-f28 N/A periodic Registry content changed
periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-ipi-boot-diagnostics-disabled-f28 N/A periodic Registry content changed
periodic-ci-openshift-verification-tests-main-installation-nightly-4.19-azure-ipi-byo-user-assigned-identity-arm-f14 N/A periodic Registry content changed
periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-ipi-boot-diagnostics-usermanaged-mini-perm-f28 N/A periodic Registry content changed
periodic-ci-openshift-verification-tests-main-installation-nightly-4.21-azure-ipi-mag-boot-diagnostics-usermanaged-f28 N/A periodic Registry content changed

A total of 48 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@gpei: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-verification-tests-main-installation-nightly-4.21-azure-stack-ipi-boot-diagnostics-usermanaged-f28 N/A periodic Registry content changed
periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-ipi-boot-diagnostics-usermanaged-mini-perm-f28 N/A periodic Registry content changed
periodic-ci-openshift-verification-tests-main-installation-nightly-4.21-azure-ipi-identity-default-mini-perm-arm-f28 N/A periodic Registry content changed
periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-ipi-identity-default-mini-perm-arm-f28 N/A periodic Registry content changed
periodic-ci-openshift-verification-tests-main-installation-nightly-4.20-azure-ipi-byo-multi-user-assigned-identity-mini-perm-arm-f28 N/A periodic Registry content changed
periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-ipi-byo-multi-user-assigned-identity-mini-perm-arm-f28 N/A periodic Registry content changed
periodic-ci-openshift-verification-tests-main-installation-nightly-4.21-azure-stack-ipi-boot-diagnostics-disabled-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.20-multi-nightly-4.20-upgrade-from-stable-4.20-azure-ipi-identity-none-mini-perm-arm-f60 N/A periodic Registry content changed
periodic-ci-openshift-verification-tests-main-installation-nightly-4.21-azure-ipi-byo-multi-user-assigned-identity-mini-perm-arm-f28 N/A periodic Registry content changed
periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-ipi-boot-diagnostics-managed-f28 N/A periodic Registry content changed
periodic-ci-openshift-verification-tests-main-installation-nightly-4.21-azure-ipi-boot-diagnostics-managed-f28 N/A periodic Registry content changed
periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-ipi-mag-boot-diagnostics-usermanaged-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.19-multi-nightly-azure-ipi-identity-none-amd-f28-destructive N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.19-multi-nightly-4.19-upgrade-from-stable-4.19-azure-ipi-identity-none-mini-perm-arm-f60 N/A periodic Registry content changed
periodic-ci-openshift-verification-tests-main-installation-nightly-4.19-azure-ipi-identity-default-arm-f28 N/A periodic Registry content changed
periodic-ci-openshift-verification-tests-main-installation-nightly-4.20-azure-ipi-mag-boot-diagnostics-usermanaged-arm-f28 N/A periodic Registry content changed
periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-ipi-identity-default-arm-f28 N/A periodic Registry content changed
periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-ipi-boot-diagnostics-disabled-f28 N/A periodic Registry content changed
periodic-ci-openshift-verification-tests-main-installation-nightly-4.19-azure-ipi-byo-multi-user-assigned-identity-mini-perm-arm-f28 N/A periodic Registry content changed
periodic-ci-openshift-verification-tests-main-installation-nightly-4.20-azure-ipi-boot-diagnostics-disabled-arm-f28 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.20-multi-nightly-azure-ipi-identity-none-mini-perm-arm-f14 N/A periodic Registry content changed
periodic-ci-openshift-verification-tests-main-installation-nightly-4.20-azure-ipi-byo-user-assigned-identity-arm-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.22-multi-nightly-azure-ipi-identity-none-amd-f28-destructive N/A periodic Registry content changed
periodic-ci-openshift-verification-tests-main-installation-nightly-4.21-azure-ipi-mag-boot-diagnostics-usermanaged-f28 N/A periodic Registry content changed
periodic-ci-openshift-verification-tests-main-installation-nightly-4.19-azure-ipi-boot-diagnostics-disabled-arm-f28 N/A periodic Registry content changed

A total of 48 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants