CNTRLPLANE-2561: Add automated PR review comment handling for HyperShift #73642
Conversation
Add a new Prow workflow that automatically addresses review comments on PRs created by the jira-agent using Claude Code's /utils:address-reviews command from the ai-helpers repository. The workflow: - Queries GitHub for open PRs from hypershift-community fork - Identifies PRs with "Generated with Claude Code" attribution - Checks for unresolved review threads using GraphQL API - Runs /utils:address-reviews on each PR with pending reviews - Pushes changes back to the fork branch This is a companion workflow to the hypershift-jira-agent that creates the initial PRs. The review-agent runs 1 hour after the jira-agent to pick up any review comments on newly created PRs. Ref: CNTRLPLANE-2561 Co-Authored-By: Claude Opus 4.5 <[email protected]>
openshift-ci-robot
added
the
jira/valid-reference
|
@bryan-cox: This pull request references CNTRLPLANE-2561 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
@bryan-cox: This pull request references CNTRLPLANE-2561 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bryan-cox The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
bryan-cox
force-pushed
the
CNTRLPLANE-2561
branch
2 times, most recently
from
3dabb78 to
b1becbc
Compare
Configure the periodic-review-agent job to run daily at 10:00 AM UTC, one hour after the jira-agent job. This allows time for the jira-agent to create PRs and for reviewers to leave comments. Configuration: - Schedule: 0 10 * * * (daily at 10:00 AM UTC) - Max PRs per run: 5 - Uses hypershift-review-agent workflow The job uses the same claude-ai-helpers image and authentication infrastructure as the jira-agent. Ref: CNTRLPLANE-2561 Co-Authored-By: Claude Opus 4.5 <[email protected]>
bryan-cox
force-pushed
the
CNTRLPLANE-2561
branch
from
b1becbc to
3465b41
Compare
|
/pj-rehearse periodic-ci-openshift-hypershift-main-periodic-review-agent |
|
@bryan-cox: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Replace regex body matching with --author filter to identify PRs created by the jira-solve GitHub App. This is more reliable than matching text patterns in PR bodies. Co-Authored-By: Claude Opus 4.5 <[email protected]>
|
/pj-rehearse periodic-ci-openshift-hypershift-main-periodic-review-agent |
|
@bryan-cox: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-hypershift-main-periodic-review-agent |
|
@bryan-cox: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Move the address-reviews.md file to /tmp/ instead of inside the hypershift git working directory. This prevents git checkout from removing the file when switching between PR branches. Co-Authored-By: Claude Opus 4.5 <[email protected]>
|
/pj-rehearse periodic-ci-openshift-hypershift-main-periodic-review-agent |
|
@bryan-cox: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
…eview threads The review-agent previously only detected inline code review threads via GraphQL reviewThreads, missing general PR comments (issue comments) from reviewers. This caused PRs like openshift#7533 to be skipped even when they had unanswered reviewer feedback. Changes: - Add API call to check for general PR comments (issue comments) - Update skip condition to process PR if either review threads OR comments exist - Remove unused PENDING_COMMENTS variable that was never referenced - Exclude bot's own comments to avoid self-triggering Co-Authored-By: Claude Opus 4.5 <[email protected]>
|
/pj-rehearse periodic-ci-openshift-hypershift-main-periodic-review-agent |
|
@bryan-cox: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[REHEARSALNOTIFIER]
A total of 34 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@bryan-cox: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
Summary
Add a Prow job that automatically addresses review comments on PRs created by the jira-solve job using Claude Code's
/utils:address-reviewscommand from the ai-helpers repository.What it does
/utils:address-reviewscommand to analyze and address review commentsWorkflow steps
Configuration
REVIEW_AGENT_MAX_PRS)Files added
ci-operator/step-registry/hypershift/review-agent/- Workflow and step definitionsci-operator/config/openshift/hypershift/openshift-hypershift-main.yaml- Periodic job configRelationship to Jira Agent
This is a companion workflow to the
hypershift-jira-agent(PR #70147):issue-for-agentlabel/jira-solve/utils:address-reviewsJira
https://issues.redhat.com/browse/CNTRLPLANE-2561
🤖 Generated with Claude Code via
/jira:solve [CNTRLPLANE-2561](https://issues.redhat.com//browse/CNTRLPLANE-2561)