⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Conversation

@sebrandon1
Copy link
Member

Summary

  • Update golangci-lint image from v1.64.8 to v2.0.2 for openshift/installer CI

Related PRs

Tracking

🤖 Generated with Claude Code

This change updates the golangci-lint image version from v1.64.8 to v2.0.2
to support the v2 configuration format in the installer repository.

Corresponding installer PR: openshift/installer#10228
Tracking: redhat-best-practices-for-k8s/telco-bot#49

Co-Authored-By: Claude Opus 4.5 <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 16, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sebrandon1
Once this PR has been reviewed and has the lgtm label, please assign patrickdillon for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@sebrandon1: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-installer-main-artifacts-images openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-aws-private openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-azure-ovn-marketplace-images openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-azure-private openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-e2e-agent-4control-ipv4 openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-e2e-agent-5control-ipv4 openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-e2e-agent-compact-ipv4 openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-e2e-agent-compact-ipv4-appliance-diskimage openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-e2e-agent-compact-ipv4-iso-no-registry openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-e2e-agent-compact-ipv4-none-platform openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-e2e-agent-compact-ipv6-minimaliso openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-e2e-agent-ha-dualstack openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-e2e-agent-sno-ipv4-pxe openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-e2e-agent-sno-ipv6 openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-e2e-agent-two-node-fencing-ipv4 openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-e2e-aws-byo-subnet-role-security-groups openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-e2e-aws-custom-dns-techpreview openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-e2e-aws-default-config openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-e2e-aws-overlay-mtu-ovn-1200 openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-e2e-aws-ovn openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-e2e-aws-ovn-custom-iam-profile openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-e2e-aws-ovn-edge-zones openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-e2e-aws-ovn-edge-zones-manifest-validation openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-e2e-aws-ovn-fips openshift/installer presubmit Ci-operator config changed
pull-ci-openshift-installer-main-e2e-aws-ovn-heterogeneous openshift/installer presubmit Ci-operator config changed

A total of 117 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 16, 2026

@sebrandon1: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@tthvo
Copy link
Member

tthvo commented Jan 16, 2026

Unfortunately, there is no v2.0.2 tag for golangci-lint here. We do have v2.3.1 mirror but it's tagged under latest.

ci/golangci-lint:latest:
image: quay.io/openshiftci/golangci-lint:v2.3.1

Brent opened #72011 to bump the version and address the mirror tag so we can close this as duplicate. WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants