-
Notifications
You must be signed in to change notification settings - Fork 2.1k
SREP-2757: Add ROSA HCP conformance testing for 4.19 and 4.20 #73650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
SREP-2757: Add ROSA HCP conformance testing for 4.19 and 4.20 #73650
Conversation
|
@dustman9000: This pull request references SREP-2757 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
1 similar comment
|
@dustman9000: This pull request references SREP-2757 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dustman9000 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f83be54 to
f701ba2
Compare
|
/pj-rehearse |
|
@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
This adds daily conformance testing for ROSA HCP clusters, similar to what already exists for ROSA Classic STS clusters. Changes: - Create rosa-aws-hcp-conformance workflow in step registry - Add e2e-rosa-hcp-ovn daily job for 4.19 and 4.20 nightly builds - Add release controller entries as informing (optional: true) The workflow provisions ROSA HCP clusters, runs openshift-tests conformance suite, and deprovisions clusters. Uses the same test skips as ROSA Classic conformance testing. Related: https://issues.redhat.com/browse/SREP-2757 Related: https://issues.redhat.com/browse/SREP-2879
f701ba2 to
a2261f9
Compare
|
/pj-rehearse |
|
@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
HCP clusters don't have the machines API on the hosted cluster, so the standard openshift-e2e-test ref fails when trying to compare machine count with node count. The hypershift-conformance chain has custom logic that handles HCP clusters correctly. Also add HOSTED_CP=true env var which the hypershift-conformance chain uses to set the correct KUBECONFIG path.
|
/pj-rehearse |
|
@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse ack |
|
@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Skip tests that are expected to fail on ROSA HCP: - etcd leader changes: known flaky on HCP, skipped in 18+ other workflows - platform components priority class: HCP architecture difference - requests but not limits: HCP architecture difference - OLM tests: OLM not deployed by default on ROSA HCP (optional capability)
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse |
|
@joshbranham: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@dustman9000: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Summary
SREP-2757 / SREP-2879
This adds daily conformance testing for ROSA HCP clusters, similar to what already exists for ROSA Classic STS clusters.
rosa-aws-hcp-conformanceworkflow in step registrye2e-rosa-hcp-ovndaily job for 4.19 and 4.20 nightly buildsoptional: true)The workflow provisions ROSA HCP clusters, runs openshift-tests conformance suite, and deprovisions clusters. Uses the same test skips as ROSA Classic conformance testing.
Related Issues
Changes
ci-operator/step-registry/rosa/aws/hcp/conformance/openshift-release-master__nightly-4.19.yamlopenshift-release-master__nightly-4.20.yamlrelease-ocp-4.19.jsonrelease-ocp-4.20.jsonpriv/release-ocp-4.19.jsonpriv/release-ocp-4.20.jsonTest Plan
/cc @joshbranham @meowfaceman