-
-
Notifications
You must be signed in to change notification settings - Fork 168
Refactor check_modules script #2893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
drgrice1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a good idea. However, I think that it may be necessary to have separate packagetype options for Debian and Ubuntu. Usually packages are the same for the two, but not always. Could that be an issue for Red Hat and Oracle?
| my %modulesList = ( | ||
| 'Archive::Tar' => { | ||
| 'package' => { | ||
| 'deb' => 'perl-modules', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change this to
| 'deb' => 'perl-modules', | |
| 'deb' => 'perl', |
There is no perl-modules package (at least for Ubuntu). There is a perl-modules-5.38 package on Ubuntu 24 which contains all of the packages you listed for the perl-modules pakcage. However it would probably be a bad idea to list that here. That would be specific to the version of Ubuntu. The perl package would be on all versions of Ubuntu, and it depends on the perl-modules-5.38 package (that would be a different Perl version for other Ubuntu versions though), and so it will be installed if the perl package is.
| }, | ||
| 'Data::Dumper' => { | ||
| 'package' => { | ||
| 'deb' => 'libperl', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change this to
| 'deb' => 'libperl', | |
| 'deb' => 'perl', |
There is also no libperl package, but there is libperl5.38t64. The perl package also depends on that.
Update the the
check_modules.plscript to add the name of the Debian and RedHat package for perl packages where available.This adds another flag when calling the script, where the user can specify if they are on a deb- or rpm-based system, and the output will suggest a command for installing any missing packages.