Do area expire based on the actual polygon instead of the bbox #2453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lonvia
reviewed
Feb 6, 2026
Expire (multi)polygons based on their shape, not the complete bounding box. We use the existing implementation for the boundary expire, to get the boundary right including the configured buffer. For the rest of the area inside the polygon we use a "polygon drawing algorithm" to figure out all tiles which are inside the polygon. This also contains some changes to the BDD test code to allow running the osm2pgsql-expire program and check its output against a file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expire (multi)polygons based on their shape, not the complete bounding box. We use the existing implementation for the boundary expire, to get the boundary right including the configured buffer. For the rest of the area inside the polygon we use a "polygon drawing algorithm" to figure out all tiles which are inside the polygon.
This also contains some changes to the BDD test code to allow running the osm2pgsql-expire program and check its output against a file.