FixedBitSet<K = usize> where K: From<usize> + Into<usize>#69
Open
bestouff wants to merge 1 commit intopetgraph:masterfrom
Open
FixedBitSet<K = usize> where K: From<usize> + Into<usize>#69bestouff wants to merge 1 commit intopetgraph:masterfrom
bestouff wants to merge 1 commit intopetgraph:masterfrom
Conversation
Collaborator
|
Thanks for the contribution! I'll take a closer look later. Backwards compatibility is important so |
Author
|
That's what I thought. It's probably better to wait that this particular issue is fixed. In the interim I made a separate crate (which is just a fork of yours with my PR applied): https://lib.rs/crates/tibitset |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's a proof-of-concept. I've kept size arguments (in
len(),with_capacity()andgrow()) asusizeto keep with the spirit of typed-index-collections and to be able to use it as a drop-in replacement forHashSet.The only roadblock I have stumbled on is that
new()still can beconstfor now.