⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Conversation

@rjaegers
Copy link
Member

🚀 Hey, I have created a Pull Request

Description of changes

This pull request updates several GitHub Actions workflow files to use the ubuntu-slim runner instead of ubuntu-latest. Additionally, it expands the list of packages cleaned up in the PR image cleanup workflow. These changes help improve resource efficiency and ensure more targeted maintenance of development resources.

Workflow runner improvements:

  • Changed the runs-on field from ubuntu-latest to ubuntu-slim in the following workflows for more lightweight and efficient CI/CD runs:
    • .github/workflows/continuous-integration.yml
    • .github/workflows/image-cleanup.yml
    • .github/workflows/issue-cleanup.yml
    • .github/workflows/issue-creation-tool-versions.yml
    • .github/workflows/ossf-scorecard.yml
    • .github/workflows/pr-conventional-title.yml
    • .github/workflows/pr-image-cleanup.yml [1] [2]
    • .github/workflows/pr-report.yml
    • .github/workflows/release-please.yml
    • .github/workflows/wc-document-generation.yml

PR image cleanup enhancements:

  • Added amp-devcontainer-base to the list of packages cleaned up by the ghcr-cleanup-action in .github/workflows/pr-image-cleanup.yml, ensuring more comprehensive image cleanup.

✔️ Checklist

  • I have followed the contribution guidelines for this repository
  • I have added tests for new behavior, and have not broken any existing tests
  • I have added or updated relevant documentation
  • I have verified that all added components are accounted for in the SBOM

@rjaegers rjaegers requested a review from a team as a code owner January 23, 2026 08:41
Copilot AI review requested due to automatic review settings January 23, 2026 08:41
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates GitHub Actions workflows to use the more lightweight ubuntu-slim runner instead of ubuntu-latest for improved resource efficiency. It also expands the PR image cleanup workflow to include the amp-devcontainer-base package.

Changes:

  • Switched 10 workflow files from ubuntu-latest to ubuntu-slim runners
  • Added amp-devcontainer-base to the list of packages cleaned up in the PR image cleanup workflow

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
.github/workflows/continuous-integration.yml Updated test results publishing job to use ubuntu-slim runner
.github/workflows/image-cleanup.yml Updated image cleanup job to use ubuntu-slim runner
.github/workflows/issue-cleanup.yml Updated stale issue cleanup job to use ubuntu-slim runner
.github/workflows/issue-creation-tool-versions.yml Updated tool version issue creation job to use ubuntu-slim runner
.github/workflows/ossf-scorecard.yml Updated OpenSSF scorecard job to use ubuntu-slim runner
.github/workflows/pr-conventional-title.yml Updated PR title validation job to use ubuntu-slim runner
.github/workflows/pr-image-cleanup.yml Updated PR image cleanup jobs to use ubuntu-slim runner and added amp-devcontainer-base to cleanup packages
.github/workflows/pr-report.yml Updated PR report job to use ubuntu-slim runner
.github/workflows/release-please.yml Updated release creation job to use ubuntu-slim runner
.github/workflows/wc-document-generation.yml Updated document generation job to use ubuntu-slim runner

@sonarqubecloud
Copy link

@github-actions
Copy link
Contributor

⚠️MegaLinter analysis: Success with warnings

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ ACTION actionlint 20 0 0 0.5s
✅ DOCKERFILE hadolint 3 0 0 0.76s
✅ GHERKIN gherkin-lint 6 0 0 2.43s
✅ JSON npm-package-json-lint yes no no 0.35s
✅ JSON prettier 21 4 0 0 0.59s
✅ JSON v8r 21 0 0 7.04s
✅ MARKDOWN markdownlint 12 0 0 0 0.98s
✅ MARKDOWN markdown-table-formatter 12 0 0 0 0.26s
✅ REPOSITORY checkov yes no no 17.27s
✅ REPOSITORY gitleaks yes no no 0.5s
✅ REPOSITORY git_diff yes no no 0.01s
✅ REPOSITORY grype yes no no 28.57s
✅ REPOSITORY secretlint yes no no 0.9s
✅ REPOSITORY syft yes no no 1.91s
✅ REPOSITORY trivy yes no no 7.77s
✅ REPOSITORY trivy-sbom yes no no 0.23s
✅ REPOSITORY trufflehog yes no no 2.28s
⚠️ SPELL lychee 80 4 0 21.64s
✅ YAML prettier 28 0 0 0 0.93s
✅ YAML v8r 28 0 0 7.91s
✅ YAML yamllint 28 0 0 0.77s

Detailed Issues

⚠️ SPELL / lychee - 4 errors
[IGNORED] docker://pandoc/extra:3.7.0@sha256:a703d335fa237f8fc3303329d87e2555dca5187930da38bfa9010fa4e690933a | Unsupported: Error creating request client: builder error for url (docker://pandoc/extra:3.7.0@sha256:a703d335fa237f8fc3303329d87e2555dca5187930da38bfa9010fa4e690933a)
[ERROR] https://www.conventionalcommits.org/en/v1.0.0/ | Network error: error sending request for url (https://www.conventionalcommits.org/en/v1.0.0/) Maybe a certificate error?
[ERROR] https://www.conventionalcommits.org/en/v1.0.0/ | Error (cached)
[ERROR] https://securityscorecards.dev/viewer/?uri=github.com/philips-software/amp-devcontainer | Network error: error sending request for url (https://securityscorecards.dev/viewer/?uri=github.com/philips-software/amp-devcontainer) Maybe a certificate error?
[403] https://developer.arm.com/downloads/-/arm-gnu-toolchain-downloads | Network error: Forbidden
[IGNORED] https://vscode.dev/redirect?url=vscode://ms-vscode-remote.remote-containers/cloneInVolume?url=https://github.com/philips-software/amp-devcontainer | Unsupported: Error creating request client: builder error for url (vscode://ms-vscode-remote.remote-containers/cloneInVolume?url=https://github.com/philips-software/amp-devcontainer)
📝 Summary
---------------------
🔍 Total..........126
✅ Successful.....120
⏳ Timeouts.........0
🔀 Redirected.......0
👻 Excluded.........0
❓ Unknown..........0
🚫 Errors...........4

Errors in .github/workflows/pr-conventional-title.yml
[ERROR] https://www.conventionalcommits.org/en/v1.0.0/ | Network error: error sending request for url (https://www.conventionalcommits.org/en/v1.0.0/) Maybe a certificate error?

Errors in README.md
[ERROR] https://www.conventionalcommits.org/en/v1.0.0/ | Error (cached)
[ERROR] https://securityscorecards.dev/viewer/?uri=github.com/philips-software/amp-devcontainer | Network error: error sending request for url (https://securityscorecards.dev/viewer/?uri=github.com/philips-software/amp-devcontainer) Maybe a certificate error?

Errors in .github/TOOL_VERSION_ISSUE_TEMPLATE.md
[403] https://developer.arm.com/downloads/-/arm-gnu-toolchain-downloads | Network error: Forbidden

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@9.3.0 --custom-flavor-setup --custom-flavor-linters ACTION_ACTIONLINT,DOCKERFILE_HADOLINT,GHERKIN_GHERKIN_LINT,JSON_V8R,JSON_PRETTIER,JSON_NPM_PACKAGE_JSON_LINT,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_GRYPE,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,SPELL_LYCHEE,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security

@github-actions
Copy link
Contributor

📦 Container Size Analysis

Note

Comparing ghcr.io/philips-software/amp-devcontainer-base:edgeghcr.io/philips-software/amp-devcontainer-base:pr-1101

📈 Size Comparison Table

OS/Platform Previous Current Change Trend
linux/amd64 165.43 MB 165.43 MB +594 B (+0%) 🔼
linux/arm64 158.37 MB 158.37 MB +101 B (+0%) 🔼

@rjaegers
Copy link
Member Author

This PR is blocked on actions/runner-images#13583.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants