Various improvements for the real time benchmark #20930
Merged
+9
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kocsismate
commented
Jan 13, 2026
kocsismate
commented
- Ubuntu is updated to 24.04
- Log files are also uploaded as artifact
- The baseline commit is now correctly set to the merge base commit when the workflow is manually started on a PR
- Ubuntu is updated to 24.04 - Log files are also uploaded as artifact - The baseline commit is now correctly set to the merge base commit when the workflow is manually started on a PR
kocsismate
changed the title
iluuu1994
approved these changes
Jan 13, 2026
Comment on lines
+299
to
+300
| ./php-version-benchmarks/tmp/results/${{ env.YEAR }}/*/*.* | ||
| ./php-version-benchmarks/tmp/results/${{ env.YEAR }}/*/*/*.log |
Member
There was a problem hiding this comment.
Can this just be:
Suggested change
| ./php-version-benchmarks/tmp/results/${{ env.YEAR }}/*/*.* | |
| ./php-version-benchmarks/tmp/results/${{ env.YEAR }}/*/*/*.log | |
| ./php-version-benchmarks/tmp/results/${{ env.YEAR }}/**/* |
Member
Author
There was a problem hiding this comment.
No, it cannot, because there are some files which I didn't want to include inside the subdirectories (e.g. *_output.txt files), but everything can be upload from the main result directory (one-level deeper from the year directory)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.