Update keywords for extraction of dpgettext and dnpgettext#1235
Merged
akx merged 1 commit intopython-babel:masterfrom Dec 29, 2025
Merged
Update keywords for extraction of dpgettext and dnpgettext#1235akx merged 1 commit intopython-babel:masterfrom
akx merged 1 commit intopython-babel:masterfrom
Conversation
7ab70cb to
b3abc0b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1235 +/- ##
=======================================
Coverage 92.07% 92.07%
=======================================
Files 27 27
Lines 4692 4692
=======================================
Hits 4320 4320
Misses 372 372
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment, the localization methods dpgettext and dnpgettext are not properly handled by extract command.
It raises KeyError exception.
except if you pass explicitly
--keyword dpgettext:2c,3 --keyword dnpgettext:2c,3,4This MR fixed the issue by declaring the default position parameter of those methods.
Traceback raised: