duplicate init files on rhel7 and rhel6#569
Open
erezzarum wants to merge 1 commit intopython-diamond:masterfrom
Open
duplicate init files on rhel7 and rhel6#569erezzarum wants to merge 1 commit intopython-diamond:masterfrom
erezzarum wants to merge 1 commit intopython-diamond:masterfrom
Conversation
- systemd >= rhel7 - init.d <= rhel6 - removed upstart.
shortdudey123
requested changes
Feb 18, 2017
| elif distro_major_version >= 6 and not distro == 'debian': | ||
| data_files.append(('/etc/init', | ||
| ['rpm/upstart/diamond.conf'])) | ||
| elif distro_major_version <= 6 and not distro == 'debian': |
Member
There was a problem hiding this comment.
this should probably be an else, otherwise debian will not get an init file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On RHEL6 both upstart and init.d were configured.
On RHEL7 both systemd and init.d were configured.
I also believe there is no need for using upstart on RHEL6, If you think there's a use for that, i'll fix my pull request.