⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.

Metal backend: fix bugs in qmv_impl #17188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

manuelcandales merged 65 commits into main from gh/manuelcandales/159/head

Feb 5, 2026

Contributor

manuelcandales commented Feb 4, 2026 •

edited

Loading

Fixes two bugs in qmv_impl (also submitted PR 3096 to MLX)

Fix 1: Changed qdot to qdot_safe when handling remaining elements in the N < 8 case
Notice that in qmv_impl, there are two code paths based on whether N < 8:
- When N >= 8: Correctly uses qdot_safe for remaining elements
- When N < 8: Incorrectly used qdot instead of qdot_safe for remaining elements (fixed in this PR)
Fix 2: Changed in_vec_size_g from floor division to ceiling division to correctly handle cases where K is not a multiple of group size

manuelcandales added 27 commits

January 30, 2026 19:25


          Update

39db621

[ghstack-poisoned]


          Update

0ed7c5c

[ghstack-poisoned]


          Update

b4310cc

[ghstack-poisoned]


          Update

94c823c

[ghstack-poisoned]


          Update

31b6f45

[ghstack-poisoned]


          Update

c68cc6b

[ghstack-poisoned]


          Update

bd7192f

[ghstack-poisoned]


          Update

bcc8bda

[ghstack-poisoned]


          Update

f166c50

[ghstack-poisoned]


          Update

[ghstack-poisoned]


          Update

ed4dcee

[ghstack-poisoned]


          Update

a058197

[ghstack-poisoned]


          Update

[ghstack-poisoned]


          Update

d3501af

[ghstack-poisoned]


          Update

fe5be37

[ghstack-poisoned]


          Update

a0e3469

[ghstack-poisoned]


          Update

fcfa832

[ghstack-poisoned]


          Update

2e50286

[ghstack-poisoned]


          Update

[ghstack-poisoned]


          Update

2e3254a

[ghstack-poisoned]


          Update

c5a3c1a

[ghstack-poisoned]


          Update

457428b

[ghstack-poisoned]


          Update

fec15bc

[ghstack-poisoned]


          Update

40ec415

[ghstack-poisoned]


          Update

c16dc59

[ghstack-poisoned]


          Update

8ee7d60

[ghstack-poisoned]


          Update

9966d37

[ghstack-poisoned]

Contributor Author

manuelcandales commented Feb 4, 2026 •

edited

Loading

Stack from ghstack (oldest at bottom):

-> Metal backend: fix bugs in qmv_impl #17188

manuelcandales requested review from cccclai and shoumikhin as code owners

February 4, 2026 00:03

manuelcandales added 5 commits

February 5, 2026 12:08


          Update

5b0e27a

[ghstack-poisoned]


          Update

b24150a

[ghstack-poisoned]


          Update

c5b3b22

[ghstack-poisoned]


          Update

6b6398c

[ghstack-poisoned]


          Update

2b0adc6

[ghstack-poisoned]

manuelcandales added a commit that referenced this pull request


          Metal backend: fix bugs in qmv_impl

c565b06

ghstack-source-id: 6c871d7
ghstack-comment-id: 3844461524
Pull-Request: #17188

manuelcandales added 5 commits

February 5, 2026 12:39


          Update

f8022a9

[ghstack-poisoned]


          Update

4edd311

[ghstack-poisoned]


          Update

3a99b50

[ghstack-poisoned]


          Update

77868a6

[ghstack-poisoned]


          Update

b0711b5

[ghstack-poisoned]

manuelcandales added a commit that referenced this pull request


          Metal backend: fix bugs in qmv_impl

6aa9193

ghstack-source-id: 5f359ec
ghstack-comment-id: 3844461524
Pull-Request: #17188

manuelcandales added 4 commits

February 5, 2026 12:53


          Update

dfb85b1

[ghstack-poisoned]


          Update

9fa2428

[ghstack-poisoned]


          Update

53a60b4

[ghstack-poisoned]


          Update

59f1b9d

[ghstack-poisoned]

manuelcandales added a commit that referenced this pull request


          Metal backend: fix bugs in qmv_impl

84e598f

ghstack-source-id: 5f359ec
ghstack-comment-id: 3844461524
Pull-Request: #17188

manuelcandales added 3 commits

February 5, 2026 13:02


          Update

678ebf1

[ghstack-poisoned]


          Update

07ee8dd

[ghstack-poisoned]


          Update

e0a0a59

[ghstack-poisoned]

manuelcandales added a commit that referenced this pull request


          Metal backend: fix bugs in qmv_impl

bd1929c

ghstack-source-id: 5f359ec
ghstack-comment-id: 3844461524
Pull-Request: #17188

manuelcandales added 2 commits

February 5, 2026 13:10


          Update

8881ce9

[ghstack-poisoned]


          Update

7701e98

[ghstack-poisoned]

manuelcandales added a commit that referenced this pull request


          Metal backend: fix bugs in qmv_impl

12a5365

ghstack-source-id: 5f359ec
ghstack-comment-id: 3844461524
Pull-Request: #17188

Base automatically changed from gh/manuelcandales/158/head to main

February 5, 2026 18:11


          Update

61dc1e2

[ghstack-poisoned]

manuelcandales added a commit that referenced this pull request


          Metal backend: fix bugs in qmv_impl

c3b83d1

ghstack-source-id: 5f359ec
ghstack-comment-id: 3844461524
Pull-Request: #17188

github-actions bot commented Feb 5, 2026

This PR needs a `release notes:` label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

manuelcandales merged commit 20703d0 into main

36 of 38 checks passed

manuelcandales deleted the gh/manuelcandales/159/head branch

February 5, 2026 18:12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels