frontend: use new sidebar assets #2137
Merged
+28
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
malinskibeniamin
commented
Jan 15, 2026
malinskibeniamin
commented
malinskibeniamin
force-pushed
the
new-sidebar-assets
branch
from
09955e0 to
b7cd08b
Compare
eblairmckee
approved these changes
Jan 16, 2026
Contributor
eblairmckee
left a comment
eblairmckee
left a comment
There was a problem hiding this comment.
Love this design so much more than current.
eblairmckee
reviewed
Jan 16, 2026
Comment on lines
-55
to
-61
| const { colorMode } = useColorMode(); | ||
|
|
||
| const isExpanded = isMobile || state === 'expanded'; | ||
| const isDark = colorMode === 'dark'; | ||
|
|
||
| const fullLogo = isDark ? RedpandaTextWhite : RedpandaTextColor; | ||
| const iconLogo = isDark ? RedpandaIconWhite : RedpandaIconColor; |
Contributor
There was a problem hiding this comment.
making an assumption here that sidebar background color doesn't change enough in dark mode to warrant a different color for the brand name text?
Contributor
Author
There was a problem hiding this comment.
Exactly. Previously we had a redpanda orange colour text, now it's just dark
Contributor
Author
There was a problem hiding this comment.
Exactly. Previously we had a redpanda orange colour text, now it's just dark
eblairmckee
approved these changes
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.