Fix the format of the readthedocs config file.#113
Fix the format of the readthedocs config file.#113eggmaster merged 1 commit intorelease-depot:masterfrom
Conversation
Docs were no longer building due to a schema change on readthedocs. Signed-off-by: Jason Guiditta <jguiditt@redhat.com>
|
Changes build docs successfully. They can be seen here: |
jpichon
left a comment
There was a problem hiding this comment.
LGTM ;)
I'm not seeing the "Changelog" link in the menu of the test docs vs the current docs, when I think it's quite handy to have, but not sure if it's just a test vs real env difference or if there was another format change somewhere.
This is a good observation, and thanks for the review! I did some looking, and I believe this is just because of how I have my test project set up on readthedocs. I have it pointed to a specific branch, and it does a shallow clone, so there are no tags. This causes our tooling which generates the changelog to give this output: I was able to verify that no tags are present in the checkout when done the way test rtd does it. If we see this is still misbehaving on merge, I will follow up with another patch fixing it, if no objections. |
|
That sounds absolutely reasonable, thank you for checking and for the explanation! |
Docs were no longer building due to a schema change on readthedocs.