fix(replace): update delimiters to respect valid js identifier chars#1938
Merged
shellscape merged 2 commits intorollup:masterfrom Oct 29, 2025
Merged
fix(replace): update delimiters to respect valid js identifier chars#1938shellscape merged 2 commits intorollup:masterfrom
shellscape merged 2 commits intorollup:masterfrom
Conversation
Collaborator
|
@danielroe thanks for the PR! Some failing tests there in CI that will need attention before we can merge. |
shellscape
approved these changes
Oct 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
@rollup/plugin-replaceThis PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
the word boundary delimiter (
\b) would not correctly handle some valid JS identifiers (like$, leading to an incorrect replacement ofsometerm$being replaced by a rule forsometerm), so I've updated delimiters to be more exhaustive.