[hist] Extend the region in which TH3::Interpolate can be used#20988
Merged
hageboeck merged 2 commits intoroot-project:masterfrom Jan 26, 2026
Merged
[hist] Extend the region in which TH3::Interpolate can be used#20988hageboeck merged 2 commits intoroot-project:masterfrom
hageboeck merged 2 commits intoroot-project:masterfrom
Conversation
hageboeck
force-pushed
the
ROOT-10678_TH3_Interpolate
branch
from
1c8765b to
d446cef
Compare
hageboeck
force-pushed
the
ROOT-10678_TH3_Interpolate
branch
from
d446cef to
a7f0d27
Compare
Test Results 22 files 22 suites 3d 10h 26m 23s ⏱️ Results for commit d77ebbd. ♻️ This comment has been updated with latest results. |
hageboeck
force-pushed
the
ROOT-10678_TH3_Interpolate
branch
from
a7f0d27 to
ed54dcd
Compare
guitargeek
reviewed
Jan 23, 2026
guitargeek
approved these changes
Jan 23, 2026
Contributor
guitargeek
left a comment
guitargeek
left a comment
There was a problem hiding this comment.
Looks very good to me! If you'd find a way to make the code easier to understand I'd welcome that, but that's optional
Previously, when a user asked to interpolate a value close to the edges of the histogram, the function would generate an error. This is inconsistent with the TH1 version of Interpolate. Here, the valid range is extended by assuming that the histogram is constant at its edges (i.e. the imaginary next bin outside the axis limits has the same bin content as the last bin inside the limits, like in TH1). From here, the trilinear interpolation proceeds as before. Fix root-project#10678
hageboeck
force-pushed
the
ROOT-10678_TH3_Interpolate
branch
from
ed54dcd to
d77ebbd
Compare
Collaborator
|
Thanks!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a user asks to interpolate a value close to the edges of an axis,
the function would generate an error. This is inconsistent with the TH1
version of Interpolate.
Here, the valid range is extended by assuming that the histogram is
constant at the axis limit (i.e. the imaginary next bin outside the axis
limits has the same bin content as the last bin inside the limits). From
here, the trilinear interpolation proceeds as usual.
Fix #10678