⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

[CMake] Don't set PATH for running tutorials and explicitly get ROOT executable from target #21003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
guitargeek merged 2 commits into from
Jan 23, 2026
Merged

[CMake] Don't set PATH for running tutorials and explicitly get ROOT executable from target #21003

guitargeek merged 2 commits into from
Jan 23, 2026

Conversation

@guitargeek
Copy link
Contributor

@guitargeek guitargeek commented Jan 23, 2026

Follows up on #20996, implementing suggestions by @hageboeck.

@guitargeek guitargeek requested a review from hageboeck January 23, 2026 13:03
@guitargeek guitargeek self-assigned this Jan 23, 2026
@guitargeek guitargeek requested a review from bellenot as a code owner January 23, 2026 13:03
hageboeck
hageboeck reviewed Jan 23, 2026
View reviewed changes
@guitargeek
[CMake] Remove PATH from environment from running tutorials
3c2a66a 
This should not be necessary. If one of the tutorials needs to use the
ROOT executables, the consistent way to do it that should be to prepend
`gROOT->GetBinDir()`.

Now that the `PATH` is not set anymore for non-Windows platforms, the
CMake code can also be simplified a bit.
@guitargeek
[CMake] Explicitly get root executable for running tutorials from target
7223fe9 
Getting the ROOT executable explicitly from the CMake target is safer in
case other ROOT installations are available on the system.
hageboeck
hageboeck reviewed Jan 23, 2026
View reviewed changes
hageboeck
hageboeck approved these changes Jan 23, 2026
View reviewed changes
Copy link
Member

@hageboeck hageboeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but better to check the behaviour of the cmake_path function.

@guitargeek
Copy link
Contributor Author

guitargeek commented Jan 23, 2026

Thanks! I studied the behavior of cmake_path locally with several printouts for some cases, and it works as intended to build these colon-separated paths (I trust it that it will correctly use semicolons on Windows 🙂 ).

@guitargeek guitargeek mentioned this pull request Jan 23, 2026
Merged
@guitargeek guitargeek merged commit fae818e into root-project:master Jan 23, 2026
28 of 29 checks passed
@guitargeek guitargeek deleted the tutorials branch January 23, 2026 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hageboeck hageboeck hageboeck approved these changes

@bellenot bellenot Awaiting requested review from bellenot bellenot is a code owner

Assignees

@guitargeek guitargeek

Labels

in:Build System

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@guitargeek @hageboeck