⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Conversation

@reddevilmidzy
Copy link
Member

Added some simple review tips

r? rustc-dev-guide

@rustbot rustbot added the S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content label Jan 15, 2026
src/git.md Outdated

### Using GitHub dev

For quick and lightweight inspection of PR changes, you can use the GitHub Dev web-based editor.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know that i'd call it "quick and lightweight". The quickest and lightweightest thing is to just click "files changes" 😅 This github.dev thing requires manually cahnging the url, waiting for it to take ages to load, and then you've got a bunch of pop ups and setup to do to get a whole IDE.

I would cut this and just say its an option

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, the wording was too strong😄 I've updated it. thanks!

@BoxyUwU BoxyUwU merged commit 1a6719f into rust-lang:main Jan 17, 2026
1 check passed
@rustbot rustbot removed the S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content label Jan 17, 2026
@reddevilmidzy reddevilmidzy deleted the tip branch January 17, 2026 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants