Conversation
composer.json
Outdated
| "homepage": "https://github.com/selective-php/image-type", | ||
| "require": { | ||
| "php": "^8.1" | ||
| "php": "8.1.* || 8.1.* || 8.2.* || 8.4.*" |
There was a problem hiding this comment.
Don't we support the PHP 8.3 version?
There was a problem hiding this comment.
Sorry my bad.
| "test:coverage": "php -d xdebug.mode=coverage -r \"require 'vendor/bin/phpunit';\" -- --configuration phpunit.xml --do-not-cache-result --colors=always --coverage-clover build/logs/clover.xml --coverage-html build/coverage" | ||
| "test:coverage": [ | ||
| "@putenv XDEBUG_MODE=coverage", | ||
| "phpunit --configuration phpunit.xml --do-not-cache-result --colors=always --display-warnings --display-deprecations --coverage-clover build/coverage/clover.xml --coverage-html build/coverage --coverage-text" |
There was a problem hiding this comment.
Could you explain this change? It seems that the original and modified command are equivalent.
There was a problem hiding this comment.
When changing phpunit, I simply adopted Odan's settings. During the first updates, I saw that he had changed it in selective/packages and thought I could do the same. Maybe that was a bit silly. But I liked the changes.
| "cs:check": [ | ||
| "@putenv PHP_CS_FIXER_IGNORE_ENV=1", | ||
| "php-cs-fixer fix --dry-run --format=txt --verbose --diff --config=.cs.php --ansi" | ||
| "php-cs-fixer fix --dry-run --format=txt --verbose --diff --config=.cs.php --ansi --allow-unsupported-php-version=yes" |
There was a problem hiding this comment.
Could you explain why adding the --allow-unsupported-php-version=yes option?
There was a problem hiding this comment.
When I run the test with composer cs:check, I get the message,
`root@2df332b08462:/var/www/html# composer cs:check
@putenv PHP_CS_FIXER_IGNORE_ENV=1
php-cs-fixer fix --dry-run --format=txt --verbose --diff --config=.cs.php --ansi
Setting PHP_CS_FIXER_IGNORE_ENV environment variable is deprecated and will be removed in 4.0, use unsupportedPhpVersionAllowed config instead.
Setting PHP_CS_FIXER_IGNORE_ENV environment variable is deprecated and will be removed in 4.0, use unsupportedPhpVersionAllowed config instead.
PHP CS Fixer 3.88.2 Folding Bike by Fabien Potencier, Dariusz Ruminski and contributors.
PHP runtime: 8.4.11
Running analysis on 1 core sequentially.
You can enable parallel runner and speed up the analysis! Please see usage docs for more information.`
The same applies to cs:check, and you should now use --allow-unsupported-php-version=yes.
That's why I changed it like this.
Edit: I found it again ... https://cs.symfony.com/doc/usage.html
`The --allow-unsupported-php-version=yes can be used to ignore any environment requirements.
Also possible via PHP_CS_FIXER_IGNORE_ENV environment variable (deprecated), which also allows the Fixer to run with required PHP extensions missing.
`
| "cs:fix": [ | ||
| "@putenv PHP_CS_FIXER_IGNORE_ENV=1", | ||
| "php-cs-fixer fix --config=.cs.php --ansi --verbose" | ||
| "php-cs-fixer fix --config=.cs.php --ansi --verbose --allow-unsupported-php-version=yes" |
There was a problem hiding this comment.
Could you explain why adding the --allow-unsupported-php-version=yes option?
There was a problem hiding this comment.
see cs:check ...
|
Thanks for the PR. Could you please add PHP 8.3 and 8.4 to the GitHub action pipeline in build.yml? Thanks. |
|
Hello! I wanted to ask if there is anything else I can do? I think I have submitted everything, or are there still problems somewhere? I am not very familiar with GitHub and pull requests, so if something is missing, please let me know so I can fix it. Kind regards, Heinrich |
|
@odan, could you enable the workflow running in the PR? I think everything is ok and it looks good for me. |
3 participants
Hello,
Here are some updates I have made.
Tests show that it should still work.
Best regards,
Heinrich Schiller