[Style API] Adds usePluginStyle hook and PluginStyle type#29
Merged
alisonjlai merged 11 commits intomainfrom Oct 7, 2025
Merged
[Style API] Adds usePluginStyle hook and PluginStyle type#29alisonjlai merged 11 commits intomainfrom
alisonjlai merged 11 commits intomainfrom
Conversation
src/client/initialize.ts
Outdated
| }, | ||
|
|
||
| style: { | ||
| subscribeToStyle(callback: (style: any) => void) { |
Contributor
There was a problem hiding this comment.
super small, can we just call these subscribe and get? Makes more sense to do style.subscribe() than style.subscribeToStyle()
Contributor
There was a problem hiding this comment.
Can you change getStyle to get?
peternandersson
previously approved these changes
Oct 6, 2025
src/client/initialize.ts
Outdated
| }, | ||
|
|
||
| style: { | ||
| subscribe(callback: (style: any) => void) { |
Contributor
There was a problem hiding this comment.
Suggested change
| subscribe(callback: (style: any) => void) { | |
| subscribe(callback: (style: PluginStyle) => void) { |
peternandersson
approved these changes
Oct 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new style API with
styleon PluginInstance. Defines thePluginStyletype, currently supportingbackgroundColor.getStyle()– fetches the current style config viawb:plugin:style:getsubscribeToStyle()– listens for live updates viawb:plugin:style:updateusePluginStyle()React hookWill update readme when this is finalized.
Sample plugin app: