feat(web-api): Add support for admin.users.getExpiration #2451
Conversation
misscoded
added
semver:minor
enhancement
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2451 +/- ##
=======================================
Coverage 93.09% 93.10%
=======================================
Files 40 40
Lines 11240 11250 +10
Branches 713 713
=======================================
+ Hits 10464 10474 +10
Misses 764 764
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
zimeg
left a comment
zimeg
left a comment
There was a problem hiding this comment.
@misscoded LGTM and thanks so much for including the generated responses with this change 🙏 ✨
I left a comment about one of those changes, but no blockers for this method 🤖
| ok?: boolean; | ||
| provided?: string; | ||
| ts?: string; | ||
| message?: ChatStopStreamResponseMessage; |
There was a problem hiding this comment.
🪓 issue(non-blocking): This should be included in the Java generated logs but I'm finding tests aren't covering this for me. Let's keep note to follow up on this - I think using generated types is correct while "message" is optional.
👁️🗨️ ramble: But I wouldn't be opposed to reverting changes of this file if that seems uncertain?
There was a problem hiding this comment.
@zimeg Why would this suddenly go missing?
There was a problem hiding this comment.
@misscoded Agh I missed this - apologies for slow response! But I think some of those arguments were added manually for a release before the Java SDK had matching attributes.
There was a problem hiding this comment.
Ah, ok! We historically have opted not to do that (for this exact reason 😄), and just use the generic Web API response type until it's updated, then swap them out. Have we changed the approach to this then, or was this a one-off? Because if types that are available for folks to use change and go missing, that's technically a breaking change.
There was a problem hiding this comment.
To prevent breaking changes should we simply leave those in for now?
Summary
Adds support for
admin.users.getExpiration(and updates generated responses). See documentation.Resolves #2420.
Requirements (place an
xin each[ ])