[v3.11.11] SAM-EM MCY Levelized Metrics Update#132
Merged
softwareengineerprogrammer merged 33 commits intomainfrom Jan 28, 2026
Merged
[v3.11.11] SAM-EM MCY Levelized Metrics Update#132softwareengineerprogrammer merged 33 commits intomainfrom
softwareengineerprogrammer merged 33 commits intomainfrom
Conversation
…preparation to add backfilled PV/LCOE rows
This was referenced Jan 27, 2026
…cs cash flow line items (WIP)
…for consistency with SAM
…ICE line items post-processing
…ncorporate into SAM-EM MCY documentation
…ion (re: full cashflow serving to clarify as discussed in NatLabRockies#444 (comment))
…ODO to deploy to local web interface for screenshot
…roject_Cape-{5,6}. Note that non-MCY examples LCOE/metrics are unaffected and cash flows are only negligibly different due to trivial differences in rounding conventions for backfilled line items
…(to address TODO)
…OR_LEVELIZED_METRICS flag
…applicable (supercedes note re: marginal rounding differences in 4431a0d commit message, with possible partial exception for Fervo_Project_Cape-4 - TBD if persisting trivial discrepancy is due to rounding convention in question, or unidentified upstream difference in convention, such as in npf.npv impl)
…, where applicable (supercedes note re: marginal rounding differences in 4431a0d commit message, with possible partial exception for Fervo_Project_Cape-4 - TBD if persisting trivial discrepancy is due to rounding convention in question, or unidentified upstream difference in convention, such as in npf.npv impl)" Reversion note/reason: Trivial rounding discrepancies exist either way, so we will prefer the more-correct rounding convention after all. This reverts commit a551546.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
SME Review
Questions
Why does SAM report LCOE in Year 0 instead of Year -1? Should GEOPHIRES follow the same convention (even for long construction periods where Year -N vs. Year 0 LCOE is significantly different)?Demonstrations of backfill calculations
Generated at d69798b:
https://gist.github.com/softwareengineerprogrammer/64bffe886046ccf70b2871369dcb14e9#file-sam-em-mcy-levelized-metrics_2026-01-26-2_separate-backfilled-rows-csv-L112:
https://gist.github.com/softwareengineerprogrammer/6e54cdf9cc9456790b01695027353855#file-sam-em-mcy-levelized-metrics_2026-01-26-2_native-backfilled-rows-csv-L112
TODO
Electricity breakeven pricefield name discrepancy NatLabRockies/GEOPHIRES-X#459Backfill pre/after-tax returns (?)(See Questions section above)Testing & Verification
test_post_processed_levelized_metricsChange Checklist:
Observe the following checklist items if your change includes a new version (see versioning notes and version management docs).
Before merging:
After merging:
git push origin refs/tags/vM.m.PAdditional metadata such as TODO items or link to your initial self-review (PR into your own fork created prior to submission)