⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Conversation

@Igor-splunk
Copy link
Collaborator

Description

What does this PR have in it?

Key Changes

Highlight the updates in specific files

Testing and Verification

How did you test these changes? What automated tests are added?

Related Issues

Jira tickets, GitHub issues, Support tickets...

PR Checklist

  • Code changes adhere to the project's coding standards.
  • Relevant unit and integration tests are included.
  • Documentation has been updated accordingly.
  • All tests pass locally.
  • The PR description follows the project's guidelines.

@coveralls
Copy link
Collaborator

coveralls commented Dec 9, 2025

Pull Request Test Coverage Report for Build 20595476173

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 86.363%

Files with Coverage Reduction New Missed Lines %
pkg/splunk/enterprise/cp.go 1 33.33%
Totals Coverage Status
Change from base Build 20342908338: 0.0%
Covered Lines: 10728
Relevant Lines: 12422

💛 - Coveralls

@kasiakoziol kasiakoziol self-requested a review December 10, 2025 06:17
Copy link
Collaborator

@patrykw-splunk patrykw-splunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Igor-splunk Igor-splunk changed the base branch from develop to main December 11, 2025 08:25
@kubabuczak
Copy link
Collaborator

why MR to main directly?

Copy link
Collaborator

@kubabuczak kubabuczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say that we should merge it to develop.
Do you have an example of execution of this workflow?

@Igor-splunk Igor-splunk changed the base branch from main to develop December 11, 2025 15:52
Comment on lines +10 to +12
pull_request_target:
types: [ opened, closed, synchronize ]

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was testing this types of triggers - it actually needs to be merged to main.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However - we need to sync develop and main regarless - let's merge it to develop and then I'll do the pipelines merge to main

@Igor-splunk Igor-splunk merged commit f8995fa into develop Jan 15, 2026
106 of 110 checks passed
@Igor-splunk Igor-splunk deleted the cla-check branch January 15, 2026 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants