-
Notifications
You must be signed in to change notification settings - Fork 127
Add a check if contributor has signed Splunk Contributor License Agreement #1640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request Test Coverage Report for Build 20595476173Details
💛 - Coveralls |
patrykw-splunk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
why MR to main directly? |
kubabuczak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say that we should merge it to develop.
Do you have an example of execution of this workflow?
32f0429 to
5e73c5f
Compare
| pull_request_target: | ||
| types: [ opened, closed, synchronize ] | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was testing this types of triggers - it actually needs to be merged to main.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
However - we need to sync develop and main regarless - let's merge it to develop and then I'll do the pipelines merge to main
Description
What does this PR have in it?
Key Changes
Highlight the updates in specific files
Testing and Verification
How did you test these changes? What automated tests are added?
Related Issues
Jira tickets, GitHub issues, Support tickets...
PR Checklist