Stop supporting params not annotated with @ ProjectedPayload
#3453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit drops support for projections if a parameter (or the parameter type) is not explicitly annotated with `@ProjectedPayload`. A warning is still logged in these cases to help user understand why the parameter is not being projected. Closes spring-projects#3301
- clarifies controller method names - groups test methods by what they are doing See spring-projects#3301
onobc
added
type: enhancement
onobc
commented
Feb 3, 2026
| @@ -115,7 +115,7 @@ public boolean supportsParameter(MethodParameter parameter) { | |||
| // Parameter annotated with @ModelAttribute | |||
| if (parameter.hasParameterAnnotation(ModelAttribute.class)) { | |||
| this.deprecationLogger.logDeprecationForParameter(parameter); | |||
Contributor
Author
There was a problem hiding this comment.
In 4.2 when we rip out the logging we will simplify this logic greatly. Leaving as-is for now so that logging remains in the proper places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit drops support for projections if a parameter (or the parameter type) is not explicitly annotated with
@ ProjectedPayload. A warning is still logged in these cases to help user understand why the parameter is not being projected.Closes #3301