Add test cases for scala handler dot notation with classes#188
Open
comp615 wants to merge 1 commit intospullara:masterfrom
Open
Add test cases for scala handler dot notation with classes#188comp615 wants to merge 1 commit intospullara:masterfrom
comp615 wants to merge 1 commit intospullara:masterfrom
Conversation
Owner
|
It looks like because the ScalaObjectHandler wraps Maps I have an issue in the dot notation. Digging into it to see how it can be fixed. |
Owner
|
I'm tracking this as an issue: #189 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing in a class as a value for the context works when you use standard notation:
{{#classValue}}
{{classMember}}
{{/classValue}}
However, it throws a notFound/guard error when referenced directly:
{{classValue.classMember}}
This added two tests to illustrate the differences, with the dot notation one failing