⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Conversation

@bigfooted
Copy link
Contributor

@bigfooted bigfooted commented Jan 27, 2026

Proposed Changes

When 2 symmetries share a node, and when the angle between the faces left and right of that node are almost identical, one of the normals gets flipped by numerical instability. this fixes the issue.

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

@bigfooted
Copy link
Contributor Author

bigfooted commented Jan 27, 2026

@bigfooted bigfooted merged commit f4f327c into develop Jan 29, 2026
37 checks passed
@bigfooted bigfooted deleted the fix_symmetry branch January 29, 2026 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants