fix: theme switch without reload #5132
Open
+281
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
7se7en72025
force-pushed
the
fix/theme-switch-no-reload-4520
branch
from
2756eb5 to
6179b63
Compare
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
1 similar comment
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
7se7en72025
force-pushed
the
fix/theme-switch-no-reload-4520
branch
from
5b3a14e to
17f7a16
Compare
Contributor
|
✅ All Jest tests passed! This PR is ready to merge. |
Contributor
Author
|
@omsuneri i did run prettier, it showed the same after 3 tries :) |
Member
|
@7se7en72025 Does it change the color of the background canvas as well? |
Contributor
Author
|
Sorry i forgot it, will commit soon. |
Contributor
|
❌ Some Jest tests failed. Please check the logs and fix the issues before merging. Failed Tests: |
Contributor
Author
|
@Commanderk3 done pls check the changes, updated video in desc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
theme now switches instantly without refreshing the whole page
added applyThemeInstantly() to update colors in real-time quick.
updates body classes, canvas bg, platformColor, meta tags
refreshes palettes and floating windows on the fly
updated tests....
sugarlabs_finalthemechangefix.mp4
fixes #4520