fix(sb_fs): make s3 fs proxy capability to unsafe feature#448
Merged
nyannyacha merged 1 commit intosupabase:mainfrom Nov 23, 2024
Merged
fix(sb_fs): make s3 fs proxy capability to unsafe feature#448nyannyacha merged 1 commit intosupabase:mainfrom
nyannyacha merged 1 commit intosupabase:mainfrom
Conversation
ed789be to
c5626d3
Compare
laktek
approved these changes
Nov 23, 2024
|
🎉 This PR is included in version 1.62.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Contributor
Author
|
https://github.com/supabase/edge-runtime/security/dependabot/18 has been dismissed |
This was referenced Nov 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
Description
According to dependabot, <=
webpki@0.22.1is vulnerable to CPU denial of service attacks.However, this version is only used for debugging and development purposes by hyper-proxy, so it can be tolerated.
Ultimately, this is a problem because aws-rust-sdk does not currently provide an appropriate hyper v1 connector, and if the issue is resolved (which does not seem likely to be resolved in the short term), the vulnerability can be completely resolved by upgrading the connector version.
The proxy feature is used very limitedly, so I am adding a feature gate to make it available only through the cargo feature to clarify its meaning.
Refs:
1: https://github.com/supabase/edge-runtime/security/dependabot/18
2: awslabs/aws-sdk-rust#169
3: tafia/hyper-proxy#38