-
-
Notifications
You must be signed in to change notification settings - Fork 226
fix: ban unencrypted direct connection to pg #2000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
WalkthroughA new ignore regex pattern was added to the PostgreSQL fail2ban filter configuration template to exclude specific host-based authentication errors from triggering bans. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @ansible/files/fail2ban_config/filter-postgresql.conf.j2:
- Line 3: The failregex currently '^.*no pg_hba\.conf entry for host
"<HOST>",.*$' in filter-postgresql.conf.j2 is too broad and will match any
pg_hba.conf mismatch; narrow it to target only unencrypted/SSL-related failures
by changing the pattern to require SSL-specific text (e.g., include "SSL off",
"connection requires SSL" or "SSL encryption" phrases) or replace the failregex
with an ignoreregex if you intend to skip these messages entirely; update the
pattern in the template so the failregex only triggers on messages containing
SSL-related keywords rather than all "no pg_hba.conf entry" errors.
We want to ban ip if unsupported connections attempts are repeatedly created (such as unencrypted, etc)
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.