Conversation
Contributor
bourdin
commented
Jul 6, 2025
bourdin
commented
- Add the option to build static or shared library
- Fixed make install
- Add the option to build static or shared library - Fixed make install
Contributor
Author
|
I am definitely not a cmake expert so I hope that this does not break anything |
certik
reviewed
Jul 7, 2025
certik
reviewed
Jul 7, 2025
Contributor
|
Thanks for the PR! I left some comments. We should also test the |
removed unused statement
Contributor
Author
|
Do you need anything else from me before merging this MR? I'd like to add a space recipe for symengine.f90, ideally pulling from master |
Contributor
|
I think this looks good. Adding tests to CI can be done in a future PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.