Add option to disable printing errors to standard output#100
Open
Nyholm wants to merge 4 commits intosymfony-tools:mainfrom
Open
Add option to disable printing errors to standard output#100Nyholm wants to merge 4 commits intosymfony-tools:mainfrom
Nyholm wants to merge 4 commits intosymfony-tools:mainfrom
Conversation
weaverryan
reviewed
Apr 24, 2021
Co-authored-by: Ryan Weaver <weaverryan+github@gmail.com>
Contributor
I'm almost 100% sure that I added
Not really, but it's a good reference (it's the most commonly used documentation build tool, so if it does something, someone probably thought about it and wanted that feature). I think it makes sense to always show errors. |
Member
Author
|
I've updated the PR. It will now just add an option to disable parsing errors on std-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is technically a BC break, but since it is an internal tool ¯\(ツ)/¯
Symfony-docs shows the errors:
https://github.com/symfony/symfony-docs/blob/5.x/.github/workflows/ci.yaml#L76-L78