Fix ExceededPageSizeIsCapped to await results indexed#9172
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a flaky test by ensuring that all expected activity executions are indexed in Elasticsearch before testing pagination behavior.
Changes:
- Modified
ExceededPageSizeIsCappedtest to useCountActivityExecutionsAPI instead ofListActivityExecutionswithin theEventuallyblock to wait for exactly 2 activities to be indexed before proceeding with pagination tests
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dandavison
reviewed
Jan 30, 2026
dandavison
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Fix ExceededPageSizeIsCapped to await results indexed
Why?
Previously, we were not correctly awaiting all expected results to be index. By using the count API in the eventually loop instead, we should be guaranteed the right number of results before proceeding
How did you test it?