(DevEx): Add knapsack pro tests and exclude initialize #1007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
😎 Merged successfully - details. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1007 +/- ##
==========================================
+ Coverage 81.19% 81.43% +0.24%
==========================================
Files 66 66
Lines 14326 14331 +5
==========================================
+ Hits 11632 11671 +39
+ Misses 2694 2660 -34 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
TylerJang27
changed the title
TylerJang27
commented
Jan 28, 2026
| exit 1 | ||
| fi | ||
|
|
||
| REPORT_COUNT=$(echo "${OUTPUT}" | grep -c "Local Flaky tests report generated" || echo "0") |
Collaborator
Author
There was a problem hiding this comment.
I acknowledge this type of assertion is brittle. I don't have a better alternative at the moment without exposing more output information from the impl itself. Imo this is fine for now, and the DevEx story is now sane enough that we can revisit when we do have more time and ideas
TylerJang27
requested review from
acatxnamedvirtue,
cmillar-trunk,
max-trunk and
mb1206
as code owners
max-trunk
approved these changes
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Took over adding smoke tests for knapsack pro. The assertions there aren't perfect, but I prefer this approach to adding custom functionality to the CLI/gem that is used exclusively in tests
Calls to initialize should not generate uploads. Notably initialize only matters when in queue mode.
Successful run