⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Conversation

@TylerJang27
Copy link
Collaborator

@TylerJang27 TylerJang27 commented Jan 30, 2026

We had the versions hard-coded before. Fixes issue here. Successful run

@trunk-io
Copy link

trunk-io bot commented Jan 30, 2026

😎 Merged successfully - details.

@TylerJang27 TylerJang27 marked this pull request as ready for review January 30, 2026 15:47
@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.53%. Comparing base (d7513ee) to head (0e283d8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1015      +/-   ##
==========================================
+ Coverage   81.24%   81.53%   +0.29%     
==========================================
  Files          69       69              
  Lines       14468    14468              
==========================================
+ Hits        11755    11797      +42     
+ Misses       2713     2671      -42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

}
]
}
# donotland
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

undo?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes thank you. Need to re-enable the lint check for that in this repo 😓

@trunk-staging-io
Copy link

trunk-staging-io bot commented Jan 30, 2026

Static BadgeStatic BadgeStatic BadgeStatic Badge

Failed Test Failure Summary Logs
does_not_print_exit_code_with_validation_reports_none The test unexpectedly succeeded when a failure was expected, indicating a test logic or configuration issue. Logs ↗︎

View Full Report ↗︎Docs

@trunk-io
Copy link

trunk-io bot commented Jan 30, 2026

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

@trunk-io trunk-io bot merged commit 20f6b35 into main Jan 30, 2026
36 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants