-
Notifications
You must be signed in to change notification settings - Fork 90
Add support for Python 3.14 #2455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… to a variable or removing it
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2455 +/- ##
==========================================
- Coverage 91.22% 91.21% -0.01%
==========================================
Files 20 20
Lines 11847 11845 -2
Branches 2300 2300
==========================================
- Hits 10807 10805 -2
Misses 569 569
Partials 471 471
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Great spots on the typos etc and the |
jeromekelleher
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All LGTM - thanks @hugovk (and nice to see you again!)
Fix typo in review
|
Hello! btw saw some nice praise in https://arxiv.org/pdf/2601.09634:
|
|
I'm picking this up and will get it merged. |
benjeffery
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, I think you found all the spots to update!
|
I have updated the rules at https://github.com/tskit-dev/msprime/settings/branch_protection_rules/17687413 so this should merge now. |
Also:
in1d