chore: prefer unittest.mock from the standard library for Python >=3.8#793
Open
a-detiste wants to merge 1 commit intotwilio:mainfrom
Open
chore: prefer unittest.mock from the standard library for Python >=3.8#793a-detiste wants to merge 1 commit intotwilio:mainfrom
a-detiste wants to merge 1 commit intotwilio:mainfrom
Conversation
Contributor
|
I see your changes. So that means if we want to support python 3.7, then mock can't be used directly? In a sense, we'll still have the dependency on unittest. Is that right? |
Author
|
Hi.
It s a partial dependency.
Distrubtions that don't support py3.7 can drop mock.
There s a special syntax for setup.py/requirements.txt to says this
dependency only applies for Python version X, I don't use it actively but I
can find examples in other projects
Le ven. 24 mai 2024, 09:10, Shubham ***@***.***> a écrit :
… I see your changes. So that means if we want to support python 3.7, then
mock can't be used directly? In a sense, we'll still have a dependency. Is
that right?
—
Reply to this email directly, view it on GitHub
<#793 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB47WUFKU3EGCCWI7A3PAGTZD3RYDAVCNFSM6AAAAABIGMCJP2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRYG42TENBUGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Author
|
@tiwarishubham635 unittest is part of the standard library |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This keeps compatibility with Python3.7