chore: Add typed stub for twilio.rest.Client + to_dict type hints fix#899
Open
al-chris wants to merge 3 commits intotwilio:mainfrom
Open
chore: Add typed stub for twilio.rest.Client + to_dict type hints fix#899al-chris wants to merge 3 commits intotwilio:mainfrom
al-chris wants to merge 3 commits intotwilio:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Summary
Clientinitializer and domain properties:twilio/rest/__init__.pyi.to_dict()methods and safer policy handling in the Knowledge module.Commits included
914845712feat: add initial typings for Twilio REST cliente70d11facfix: add type hints and improve policy handling in to_dict methodsFiles changed
twilio/rest/__init__.pyitwilio/rest/knowledge/v1/knowledge/__init__.py(type hints and policy handling in multipleto_dictmethods)Why
.pyistub improves IDE/autocomplete and prepares the codebase for static typing.to_dict()is correctly typed and avoid attribute errors whenpolicyobjects do not implementto_dict().Patch summary for knowledge module (selected excerpt)
Commit: e70d11f
Message: fix: add type hints and improve policy handling in to_dict methods
Diff excerpt:
--- a/twilio/rest/knowledge/v1/knowledge/init.py
+++ b/twilio/rest/knowledge/v1/knowledge/init.py
@@
(Repeated in multiple classes:
KnowledgeInstance,KnowledgeContext,KnowledgeList— eachto_dictnow has a-> Dict[str, Any]return annotation and saferpolicyhandling.)How to test
Notes
.pyifile is annotation-only and doesn't change runtime behavior.policyobjects.Suggested branch/commit
add/stubs/twilio-rest-client914845712,e70d11facRequesting review from
twilio.restandknowledgemodulesChecklist
If you have questions, please file a support ticket, or create a GitHub Issue in this repository.